Prevent boxing allocation for Inertia.Html

mergehez · mergehez · commit 9e866528d04b · 2024-10-13T17:06:31.000+02:00
diff --git a/InertiaNetCore/Inertia.cs b/InertiaNetCore/Inertia.cs
@@ -19,9 +19,9 @@ public static class Inertia
     
     public static Response Render(string component, Dictionary<string, object?>? props) => _factory.Render(component, InertiaProps.Create(props));
 
-    public static Task<IHtmlContent> Head(dynamic model) => _factory.Head(model);
+    public static Task<IHtmlContent> Head(InertiaPage model) => _factory.Head(model);
 
-    public static Task<IHtmlContent> Html(dynamic model) => _factory.Html(model);
+    public static Task<IHtmlContent> Html(InertiaPage model) => _factory.Html(model);
 
     public static void SetVersion(object? version) => _factory.SetVersion(version);
 
diff --git a/InertiaNetCore/ResponseFactory.cs b/InertiaNetCore/ResponseFactory.cs
@@ -40,7 +40,7 @@ public async Task<IHtmlContent> Head(dynamic model)
         return response.Value.GetHead();
     }
 
-    public async Task<IHtmlContent> Html(dynamic model)
+    public async Task<IHtmlContent> Html(InertiaPage model)
     {
         if (options.Value.SsrEnabled)
         {
@@ -49,7 +49,7 @@ public async Task<IHtmlContent> Html(dynamic model)
             var response = context.Features.Get<SsrResponse?>();
             response ??= await ssrGateway.Dispatch(model, options.Value.SsrUrl);
 
-            if (response.Value != default)
+            if (response != null && response.Value != default)
             {
                 context.Features.Set(response);
                 return response.Value.GetBody();
diff --git a/README.md b/README.md
@@ -287,6 +287,7 @@ If you want to enable SSR in your Inertia app, remember to add `Inertia.Head()`
 
 ```diff
 @using InertiaNetCore
+@model InertiaNetCore.InertiaPage
 
 <!DOCTYPE html>
 <html lang="en">

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public async Task<IHtmlContent> Head(dynamic model)`
`40`	`40`	`return response.Value.GetHead();`
`41`	`41`	`}`
`42`	`42`
`43`		`- public async Task<IHtmlContent> Html(dynamic model)`
	`43`	`+ public async Task<IHtmlContent> Html(InertiaPage model)`
`44`	`44`	`{`
`45`	`45`	`if (options.Value.SsrEnabled)`
`46`	`46`	`{`
`@@ -49,7 +49,7 @@ public async Task<IHtmlContent> Html(dynamic model)`
`49`	`49`	`var response = context.Features.Get<SsrResponse?>();`
`50`	`50`	`response ??= await ssrGateway.Dispatch(model, options.Value.SsrUrl);`
`51`	`51`
`52`		`- if (response.Value != default)`
	`52`	`+ if (response != null && response.Value != default)`
`53`	`53`	`{`
`54`	`54`	`context.Features.Set(response);`
`55`	`55`	`return response.Value.GetBody();`