-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide templates and assets #3545
Draft
de-jcup
wants to merge
15
commits into
develop
Choose a base branch
from
feature-3521-templates-and-assets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
3 times, most recently
from
October 25, 2024 06:12
5cce323
to
ad4ca93
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
October 25, 2024 07:04
ad4ca93
to
27232ad
Compare
de-jcup
changed the title
Feature 3521 templates and assets
Provide templates and assets
Oct 25, 2024
- usecases for asset CRUD operations - AssertFile entity + DB parts - assert service - TestUtil enhanced, now a dedicated sub folder can be defined for temporary files - implemented asset storages (+ AbstractSharedVolumeStorage) - introduced asset storage factories
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
November 11, 2024 09:09
6e1dacb
to
7332704
Compare
- formatted code - wrote unit tests - wrote integration test - wrote DB tests - wrote RESTdoc tests - implemented logic inside asset service - wrote DAUI actions - added missing license headers
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
November 11, 2024 15:32
f9c63f7
to
eca68d8
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
3 times, most recently
from
November 15, 2024 12:05
4b7af4c
to
5c13f87
Compare
- it is now ensured on every pds job call, that the assets in storage are same as in db. Same logic for admin create/update operation is used. - improved PDSWebScanJobScenario12IntTest which does now uses templates and assets. The test ensures that the PDS instance will receive the pds template meta data. - changed templateDefinition format. Assets now no longer an array but only one entry. Means we have 1:n relation here from asset to templates and no longer m:n. - added unit tests - introduced TemplateData resolver in commons-model which can be used from PDS and wrapper applications - introduced TemplateData inside SecHub convfiguration file - Template and Asset REST controller are now annotated with profile admin access
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
November 15, 2024 13:38
5c13f87
to
e346ecf
Compare
- introduced TestAPI.executeResilient which is a short term for executeRunnableAndAcceptAssertionsMaximumTimes(4, runnable, 500); - all time relevant parts inside integration test TemplateScenario1IntTest do now use this for testing
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
November 18, 2024 15:00
404adcb
to
3f6e709
Compare
- introduced new usecase for PDS job execution (makes it easier for developers to find the relevant parts)
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
November 20, 2024 09:14
7e7f2a1
to
426b7c9
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
November 20, 2024 10:04
426b7c9
to
d4e4399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR