Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meow-undo comments line instead of undoing #109

Closed
anhsirk0 opened this issue Dec 8, 2021 · 7 comments
Closed

meow-undo comments line instead of undoing #109

anhsirk0 opened this issue Dec 8, 2021 · 7 comments

Comments

@anhsirk0
Copy link

anhsirk0 commented Dec 8, 2021

meow version: 20211207
Layout: Qwerty Layout
I downloaded meow via package-install

pressing 'u' or M-x meow-undo doesnot undo instead it comments current line

@skmd0
Copy link
Member

skmd0 commented Dec 8, 2021

Can you post your meow config here? It will maybe help with the issue.

@anhsirk0
Copy link
Author

anhsirk0 commented Dec 8, 2021

;; Meow setup
(defun meow-setup ()
;; (setq meow-cheatsheet-layout meow-cheatsheet-layout-qwerty)

(meow-motion-overwrite-define-key
'("j" . meow-next)
'("k" . meow-prev))
(meow-leader-define-key
;; SPC j/k will run the original command in MOTION state.
'("j" . "H-j")
'("k" . "H-k")
;; Use SPC (0-9) for digit arguments.
'("1" . meow-digit-argument)
'("2" . meow-digit-argument)
'("3" . meow-digit-argument)
'("4" . meow-digit-argument)
'("5" . meow-digit-argument)
'("6" . meow-digit-argument)
'("7" . meow-digit-argument)
'("8" . meow-digit-argument)
'("9" . meow-digit-argument)
'("0" . meow-digit-argument)
'("/" . meow-keypad-describe-key)
'("?" . meow-cheatsheet))
(meow-normal-define-key
'("0" . meow-expand-0)
'("9" . meow-expand-9)
'("8" . meow-expand-8)
'("7" . meow-expand-7)
'("6" . meow-expand-6)
'("5" . meow-expand-5)
'("4" . meow-expand-4)
'("3" . meow-expand-3)
'("2" . meow-expand-2)
'("1" . meow-expand-1)
'("-" . negative-argument)
'(";" . meow-reverse)
'("," . meow-inner-of-thing)
'("." . meow-bounds-of-thing)
'("[" . meow-beginning-of-thing)
'("]" . meow-end-of-thing)
'("a" . meow-append)
'("A" . meow-open-below)
'("b" . meow-back-word)
'("B" . meow-back-symbol)
'("c" . meow-change)
'("d" . meow-delete)
'("D" . meow-backward-delete)
'("e" . meow-next-word)
'("E" . meow-next-symbol)
'("f" . meow-find)
'("g" . meow-cancel-selection)
'("G" . meow-grab)
'("h" . meow-left)
'("H" . meow-left-expand)
'("i" . meow-insert)
'("I" . meow-open-above)
'("j" . meow-next)
'("J" . meow-next-expand)
'("k" . meow-prev)
'("K" . meow-prev-expand)
'("l" . meow-right)
'("L" . meow-right-expand)
'("m" . meow-join)
'("n" . meow-search)
'("o" . meow-block)
'("O" . meow-to-block)
'("p" . meow-yank)
'("q" . meow-quit)
'("Q" . meow-goto-line)
'("r" . meow-replace)
'("R" . meow-swap-grab)
'("s" . meow-kill)
'("t" . meow-till)
'("u" . meow-undo)
'("U" . meow-undo-in-selection)
'("v" . meow-visit)
'("w" . meow-mark-word)
'("W" . meow-mark-symbol)
'("x" . meow-line)
'("X" . meow-goto-line)
'("y" . meow-save)
'("Y" . meow-sync-grab)
'("z" . meow-pop-selection)
'("'" . repeat)
'("" . mode-line-other-buffer))
)

(require 'meow)
(meow-setup)
(meow-global-mode 1)

@anhsirk0
Copy link
Author

anhsirk0 commented Dec 8, 2021

I just removed my original config, and just added meow config
undo works fine now. My other config must the culprit.
but even when i call it (meow config) in the end of init.el, problem still persists

@DogLooksGood
Copy link
Collaborator

DogLooksGood commented Dec 8, 2021

It is because meow calls underlying command through keybinds, not command name. So you may want to change this variable. The value should be your undo keybinding.

We need to mention this in document.

@anhsirk0
Copy link
Author

anhsirk0 commented Dec 8, 2021

That makes sense.
I use that keybinding for commenting.
Thanks I will remove it from my config.
Thanks again!

@DogLooksGood
Copy link
Collaborator

@skmd0 Hi, can you help me with some document for this?

@skmd0
Copy link
Member

skmd0 commented Dec 9, 2021

Yeah I can try.

@skmd0 skmd0 mentioned this issue Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants