Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove null parameter signatures for tap #198

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

9renpoto
Copy link
Collaborator

@9renpoto 9renpoto commented Feb 28, 2021

closes #180

import { of } from 'rxjs';
import { tap } from 'rxjs/operators';

const source = of(3, 2, 1);

source.pipe(
  // Deprecated
  tap(null, null, () => console.log('Complete. Cookie time.'))
).subscribe(...);

source.pipe(
  // Recommended
  tap({
    complete: () => console.log('Complete. Cookie time.')
  })
).subscribe(...);

refs: https://dzhavat.github.io/2019/02/17/deprecations-in-rxjs-v6-4-0.html

@9renpoto 9renpoto self-assigned this Feb 28, 2021
@coveralls
Copy link

coveralls commented Feb 28, 2021

Pull Request Test Coverage Report for Build 615237756

  • 9 of 13 (69.23%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 87.963%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/raven.interceptor.ts 9 13 69.23%
Totals Coverage Status
Change from base Build 609461535: 0.2%
Covered Lines: 61
Relevant Lines: 66

💛 - Coveralls

@9renpoto 9renpoto added the enhancement New feature or request label Feb 28, 2021
@9renpoto
Copy link
Collaborator Author

@kayvaninvemo can you review it ? thank you :)

@9renpoto 9renpoto added this to the v7.2.0 milestone Feb 28, 2021
Copy link

@karianpour karianpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the RxJs new interface

Copy link
Owner

@mentos1386 mentos1386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the work you do @9renpoto!

@mentos1386 mentos1386 merged commit 57132be into master Mar 2, 2021
@mentos1386 mentos1386 deleted the fix/deprecated-tap-interface branch March 2, 2021 19:41
@9renpoto 9renpoto mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tap is deprecated
4 participants