Skip to content

Commit 9614c62

Browse files
committed
fix: update margin and padding properties to use logical properties for rtl support
1 parent cd866d2 commit 9614c62

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

packages/pluggableWidgets/combobox-web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We fixed an issue where right-to-left text orientation would cause layout and spacing issues.
12+
913
## [2.6.1] - 2025-10-08
1014

1115
### Fixed

packages/pluggableWidgets/combobox-web/src/ui/Combobox.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ $cb-skeleton-dark: #d2d2d2;
120120
background-color: var(--color-default-light, $cb-highlighted-index);
121121
}
122122
& > .widget-combobox-icon-container {
123-
margin-right: var(--dropdown-outer-padding, $cb-menu-outer-padding);
123+
margin-inline-end: var(--dropdown-outer-padding, $cb-menu-outer-padding);
124124
}
125125

126126
.widget-combobox-caption-text {
@@ -205,15 +205,15 @@ $cb-skeleton-dark: #d2d2d2;
205205
}
206206

207207
& + .widget-combobox-down-arrow {
208-
border-left: 1px solid var(--gray, $cb-separator-border);
208+
border-inline-start: 1px solid var(--gray, $cb-separator-border);
209209
}
210210
}
211211
&-down-arrow {
212212
display: flex;
213213
flex-wrap: wrap;
214214
align-content: center;
215215
cursor: pointer;
216-
padding-left: var(--spacing-smaller, $cb-spacing);
216+
padding-inline-start: var(--spacing-smaller, $cb-spacing);
217217

218218
&-icon {
219219
transition: transform 0.2s;
@@ -234,8 +234,8 @@ $cb-skeleton-dark: #d2d2d2;
234234
&-text {
235235
color: var(--cb-text-color, var(--gray-darker, $cb-typography-color));
236236
position: absolute;
237-
left: 0;
238-
right: 0;
237+
inset-inline-start: 0;
238+
inset-inline-end: 0;
239239
top: 0;
240240
bottom: 0;
241241
text-overflow: ellipsis;
@@ -265,8 +265,8 @@ $cb-skeleton-dark: #d2d2d2;
265265
&:placeholder-shown {
266266
position: absolute;
267267
top: 0;
268-
left: 0;
269-
right: 0;
268+
inset-inline-start: 0;
269+
inset-inline-end: 0;
270270
bottom: 0;
271271
}
272272
&:focus:not(:placeholder-shown) + .widget-combobox-placeholder-custom {
@@ -385,7 +385,7 @@ $cb-skeleton-dark: #d2d2d2;
385385
width: 148px;
386386

387387
&-small {
388-
margin-right: 8px;
388+
margin-inline-end: 8px;
389389
width: 16px;
390390
}
391391
}

0 commit comments

Comments
 (0)