Skip to content

Commit 2c28d48

Browse files
author
Illia Obukhau
committed
style(barcode-scanner-web): change error messages
1 parent fbe78de commit 2c28d48

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

packages/pluggableWidgets/barcode-scanner-web/src/components/__tests__/BarcodeScanner.spec.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ describe("Barcode scanner", () => {
7373
await act(async () => {
7474
render(<BarcodeScanner class="" showMask {...dimensions} />);
7575
});
76-
await waitFor(() =>
77-
expect(screen.getByText(/Error/i)).toHaveTextContent("Error in barcode scanner: some error message")
78-
);
76+
await waitFor(() => expect(screen.getByText(/some error message/i)).toBeVisible());
7977
});
8078

8179
it("in the form of text when the code scanner unexpectedly fails", async () => {
@@ -90,11 +88,7 @@ describe("Barcode scanner", () => {
9088
await act(async () => {
9189
render(<BarcodeScanner class="" showMask {...dimensions} />);
9290
});
93-
await waitFor(() =>
94-
expect(screen.getByText(/Error/i)).toHaveTextContent(
95-
"Error in barcode scanner: Unable to decode from stream"
96-
)
97-
);
91+
await waitFor(() => expect(screen.getByText(/Unable to decode from stream/i)).toBeVisible());
9892
});
9993
});
10094
});

packages/pluggableWidgets/barcode-scanner-web/src/hooks/useCustomErrorMessage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ type UseCustomErrorMessageHook = () => [string | null, ErrorCb];
66

77
function getErrorMessage<E extends Error>(error: E): string | null {
88
if (error instanceof Error) {
9-
return `Error in barcode scanner: ${error.message}`;
9+
return error.message;
1010
}
1111

12-
return "Error in barcode scanner: an unexpected error.";
12+
return "Unexpected error in barcode scanner.";
1313
}
1414

1515
export const useCustomErrorMessage: UseCustomErrorMessageHook = () => {

0 commit comments

Comments
 (0)