Skip to content

Commit 0cacb46

Browse files
committed
fix: wrong selection color on multi select
1 parent 363a10e commit 0cacb46

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

packages/pluggableWidgets/combobox-web/src/__tests__/__snapshots__/MultiSelection.spec.tsx.snap

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ exports[`Combo box (Association) adds new item to inital selected item 1`] = `
8686
role="listbox"
8787
>
8888
<li
89-
class="widget-combobox-item widget-combobox-item-highlighted"
89+
aria-selected="true"
90+
class="widget-combobox-item widget-combobox-item-selected"
9091
id="downshift-12-item-0"
9192
role="option"
9293
>
@@ -117,6 +118,7 @@ exports[`Combo box (Association) adds new item to inital selected item 1`] = `
117118
</span>
118119
</li>
119120
<li
121+
aria-selected="false"
120122
class="widget-combobox-item widget-combobox-item-highlighted"
121123
id="downshift-12-item-1"
122124
role="option"
@@ -149,6 +151,7 @@ exports[`Combo box (Association) adds new item to inital selected item 1`] = `
149151
</span>
150152
</li>
151153
<li
154+
aria-selected="false"
152155
class="widget-combobox-item"
153156
id="downshift-12-item-2"
154157
role="option"
@@ -181,6 +184,7 @@ exports[`Combo box (Association) adds new item to inital selected item 1`] = `
181184
</span>
182185
</li>
183186
<li
187+
aria-selected="false"
184188
class="widget-combobox-item"
185189
id="downshift-12-item-3"
186190
role="option"

packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelectionMenu.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ export function MultiSelectionMenu({
3838
return (
3939
<ComboboxOptionWrapper
4040
key={item}
41-
isHighlighted={isSelected || isActive}
41+
isHighlighted={isActive}
42+
isSelected={isSelected}
4243
item={item}
4344
getItemProps={getItemProps}
4445
index={index}

0 commit comments

Comments
 (0)