Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file type parametric #45

Closed
ismailsimsek opened this issue Oct 26, 2021 · 0 comments · Fixed by #46
Closed

Make file type parametric #45

ismailsimsek opened this issue Oct 26, 2021 · 0 comments · Fixed by #46

Comments

@ismailsimsek
Copy link
Member

use GenericAppenderFactory to create append and delete files that should enable making file type (parquet, orc, avro) parametric, which we could read from application.properties

current:

 FileAppender<Record> writer;
 writer = Parquet.write(out)
        .createWriterFunc(GenericParquetWriter::buildWriter)
        .forTable(icebergTable)
        .overwrite()
        .build();

new:

GenericAppenderFactory apender = new GenericAppenderFactory(icebergTable.schema(), icebergTable.spec());
FileAppender<Record> writer = apender.newAppender(out, FileFormat.PARQUET);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant