Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mg_client_version returns 1.7.1 even if 1.7.3 #67

Closed
toge opened this issue Aug 25, 2024 · 2 comments · Fixed by #69
Closed

mg_client_version returns 1.7.1 even if 1.7.3 #67

toge opened this issue Aug 25, 2024 · 2 comments · Fixed by #69

Comments

@toge
Copy link

toge commented Aug 25, 2024

I read the policy about minor version in the comments.
Is there some policy about when mg_client_version should be upgraded?

project(mgclient VERSION 1.4.1)
...
add_definitions(-DMGCLIENT_VERSION="${mgclient_VERSION}")

https://github.com/memgraph/mgclient/blob/master/CMakeLists.txt#L22-L27
@gitbuda
Copy link
Member

gitbuda commented Aug 25, 2024 •
edited
Loading

@toge you right 😃 That was a mistake on my side -> will take a look at how to best bump the version in the following days or on the next release 👀

Thank you!

@gitbuda gitbuda mentioned this issue Aug 30, 2024
Merged
@toge
Copy link
Author

toge commented Sep 5, 2024

@gitbuda
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the version number and prepare the next release memgraph/mgclient
2 participants
@toge @gitbuda