Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent context-menu behavior #23

Closed
r2evans opened this issue Feb 24, 2024 · 0 comments
Closed

inconsistent context-menu behavior #23

r2evans opened this issue Feb 24, 2024 · 0 comments

Comments

@r2evans
Copy link

r2evans commented Feb 24, 2024

Possibly related to #22, but it works in one mode but not another.

  • Sometimes the context-menu shows "incompatible format" for a screenshot pasted;
  • Other times it shows "Resize this image ..." for the same thing (take a screenshot, Ctrl-V paste);
  • At all times, the auto-resize yes/no option works.
  • While writing this image, I pasted and deleted screenshots multiple times, and now even though the draft email is empty and I paste a single image, it is tracking multiple images that may be resized. Closing and restarting a new draft resets this logic.

I can take a screenshot, paste into the email, and it asks if I want to resize (or I can right-click and "Resize this image...").

image

From there, the popup correctly shows the current dimensions/file-size, and the file is large enough (both in dims and size) for a resize.

image

After I click on "Okay", the modal disappears and the image/email are unchanged. If I right-click and attempt to resize again, the image dimensions/size are unchanged.

My "Shrunked" settings:

image


Now, if I repaste that image, sometimes it says that it is not recognized:

image

though clicking on the "Resize disabled:" context menu still brings up the resizing modal.

If instead I accept the "Resize this image?" or "Resize these images?" Yes on the bottom, the image is resized as intended.


Console log:

image

Log at timestamp 11:07:23:557
11:07:23.557 WebExtensions: Unexpected return: 
Array [ File ]
​
0: File { lastModified: 1708790843556, size: 12965, type: "image/jpeg", … }
​​
blobImplType: "StreamBlobImpl[StreamBlobImpl[MultipartBlobImpl[MemoryBlobImpl]]]"
​​
lastModified: 1708790843556
​​
mozFullPath: ""
​​
name: ""
​​
size: 12965
​​
type: "image/jpeg"
​​
webkitRelativePath: ""
​​
<prototype>: FilePrototype { name: Getter, lastModified: Getter, webkitRelativePath: Getter, … }
​​​
constructor: function ()
​​​
lastModified: 
​​​
mozFullPath: 
​​​
name: 
​​​
webkitRelativePath: 
​​​
Symbol(Symbol.toStringTag): "File"
​​​
<get lastModified()>: function lastModified()
​​​
<get mozFullPath()>: function mozFullPath()
​​​
<get name()>: function name()
​​​
<get webkitRelativePath()>: function webkitRelativePath()
​​​
<prototype>: BlobPrototype { slice: slice(), stream: stream(), text: text(), … }
​
length: 1
​
<prototype>: Array []
shrunked.js:99

Log at timestamp 11:12:43.958
11:12:43.958 WebExtensions: Unexpected return: 
Array [ File ]
​
0: File { lastModified: 1708791163957, size: 11526, type: "image/jpeg", … }
​​
blobImplType: "StreamBlobImpl[StreamBlobImpl[MultipartBlobImpl[MemoryBlobImpl]]]"
​​
lastModified: 1708791163957
​​
mozFullPath: ""
​​
name: ""
​​
size: 11526
​​
type: "image/jpeg"
​​
webkitRelativePath: ""
​​
<prototype>: FilePrototype { name: Getter, lastModified: Getter, webkitRelativePath: Getter, … }
​​​
constructor: function ()
​​​
lastModified: 
​​​
mozFullPath: 
​​​
name: 
​​​
webkitRelativePath: 
​​​
Symbol(Symbol.toStringTag): "File"
​​​
<get lastModified()>: function lastModified()
​​​
<get mozFullPath()>: function mozFullPath()
​​​
<get name()>: function name()
​​​
<get webkitRelativePath()>: function webkitRelativePath()
​​​
<prototype>: BlobPrototype { slice: slice(), stream: stream(), text: text(), … }
​
length: 1
​
<prototype>: Array []
shrunked.js:99

Ubuntu-23.10 on Wayland.
Betterbird-115.8.0-bb24, Shrunked-5.7.1.
The only other extension enabled is Nostalgy++-4.1.4.

If you're not familiar with Betterbird: I understand you may not be looking to explicitly support non-TB. BB is forked from TB, maintained with hours/days of TB's releases, and pushes PRs back to TB (even though TB is woefully behind on many patches in general). In my experience BB has no extension-incompatibility issues with TB. I use other extensions (only one other currently, but others historically), and none of them work in TB and don't work in BB.

@memeller memeller mentioned this issue Feb 27, 2024
memeller added a commit that referenced this issue Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant