Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For non-resizeable attachments, like PDFs, displays "Resize disabled: unsupported file format" #13

Closed
Betterbird opened this issue Dec 4, 2023 · 4 comments

Comments

@Betterbird
Copy link

Please suppress this menu entry, it's confusing, no one wants to resize PDFs.

image

@GoczkuPL
Copy link

GoczkuPL commented Dec 8, 2023

Why no one? Compressing PDFs will be something fabulous for some users :)

@Betterbird
Copy link
Author

Well, whichever type can't be compressed shouldn't show the menu entry.

@memeller
Copy link
Owner

memeller commented Dec 9, 2023

This was added in one of the first commits when, for example, bmp files were not supported. I added this information because I was confused as to why there was no option to resize the bmp file when right clicking on it, because I had forgotten that bmp files were not supported.
While showing this information (rather than hiding the menu item) still seems like a better solution for me, I also accept that other users may not share this view, so I will add the option to change the behaviour of the context menu.

memeller added a commit that referenced this issue Dec 9, 2023
Added auto resize (#12)
Added option to hide context info when file is not supported (#13)
Added reload of settings each time compose window is created
Small fixes
@memeller
Copy link
Owner

memeller commented Dec 9, 2023

This option was added in the latest release (5.7).

@memeller memeller closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants