Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve <rateLimiter /> doc #644

Open
rrayst opened this issue Jun 30, 2023 · 0 comments
Open

improve <rateLimiter /> doc #644

rrayst opened this issue Jun 30, 2023 · 0 comments

Comments

@rrayst
Copy link
Contributor

rrayst commented Jun 30, 2023

Most setups will have one trusted gateway in front of Membrane.

Therefore the use case RateLimitInterceptorTest.getClientIpTrustXForwardedFor() should be highlighted (and described) in the Javadoc as well as in the examples/rateLimiter/proxies.xml.

The Javadoc could also mention (as the comment in the getClientIpTrustXForwardedFor() does) that by the time the interceptor is called, Membrane will (in most setups) have added the remote IP to X-Forwarded-For.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant