Adds QNames antiquote production. #726
Open
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krame505
approved these changes
Nov 4, 2022
krame505
requested changes
Nov 6, 2022
| @@ -51,6 +51,14 @@ top::QNames ::= id1::QNameWithTL ',' id2::QNames | |||
| top.qnames = [id1] ++ id2.qnames; | |||
| } | |||
|
|
|||
| abstract production qNamesError | |||
There was a problem hiding this comment.
This "error" production doesn't actually flow up the errors in msg, since errors doesn't occur on QNames. This production isn't needed anyway, see my comment below.
| { | ||
| top.unparse = s"$$QNames{${e.unparse}}"; | ||
| forwards to | ||
| qNamesError( |
There was a problem hiding this comment.
This can be qNamesSingle(qNameWithTL(qNameError(...), botlNone()) to avoid adding a new "error" production that is only useful here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds Antiquote productions for QNames
Documentation
The changes made by this PR are short, and do not require specific documentation as they are small additions to the metatranslation antiquotes.