Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build files on build/ folder #517

Closed
ellisonleao opened this issue Jun 9, 2014 · 6 comments
Closed

Build files on build/ folder #517

ellisonleao opened this issue Jun 9, 2014 · 6 comments

Comments

@ellisonleao
Copy link
Contributor

Hey guys, i was wondering why we don't have the build files on the build/ folder. I am asking this because i've added the melonJS project on jsDelivr and they now have an auto-update feature who checks for updates on the build files from the repo. Perhaps we could add the stable melon.js and melon.min.js versions on the build/ folder so we can use this feature. What do you guys think?

@aaschmitz
Copy link
Contributor

Nice 👍

@parasyte
Copy link
Collaborator

parasyte commented Jun 9, 2014

Actually I do not want to commit build files directly to the repo. I would rather take an approach similar to what jQuery does. See #508 for details.

@ellisonleao
Copy link
Contributor Author

Hey @parasyte, that's a nice approach. I understand that we need a better release strategy but i think this issue is only to give us the opportunity to use this fantastic CDN on our projects. I think by having many options and not just a npm package or a bower package can increase the facility of rapid development and prototyping.

From my perspective we can create a script that:

  • Tag the new version on the repo and:
    • Creates a npm package
    • Creates a bower package
    • add the minified version on the build/ folder

@parasyte
Copy link
Collaborator

@ellisonleao the release strategy will put a zip file on github, and a commit id that contains the fully built (and minimized) js files. But those files won't be committed to the master or dev branches. You should still be able to use the cdn if it allows picking specific commit ids.

@agmcleod
Copy link
Collaborator

@parasyte Should this one be closed?

@parasyte
Copy link
Collaborator

I guess so. It seems #508 will implement the feature "good enough"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants