Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @web/test-runner-visual-regression patch once upstream is fixed #2328

Open
melink14 opened this issue Dec 19, 2024 · 5 comments
Open

Remove @web/test-runner-visual-regression patch once upstream is fixed #2328

melink14 opened this issue Dec 19, 2024 · 5 comments

Comments

@melink14
Copy link
Owner

melink14 commented Dec 19, 2024 •
edited
Loading

https://github.com/melink14/rikaikun/blob/main/patches/%40web%2Btest-runner-visual-regression%2B0.9.0.patch

Adds page.bringToFront() before taking screenshots.

Once upstream is updated, we can just use patch-package to remove the patch I think.

@SnoozeThis modernweb-dev/web#2849 <= 1 month
@SnoozeThis
Copy link

(https://snoozeth.is/bZxpDGvDXns) I will wait until modernweb-dev/web#2849 is closed and then reassign to you (until at most Sun, 19 Jan 2025 09:59:04 UTC).

@SnoozeThis
Copy link

The deadline passed while snoozing.

@melink14
Copy link
Owner Author

@SnoozeThis modernweb-dev/web#2849 <= 1 month

@SnoozeThis
Copy link

(https://snoozeth.is/8kfyzCWUtCo) I will wait until modernweb-dev/web#2849 is closed and then reassign to you (until at most Sat, 01 Mar 2025 09:17:42 UTC).

@SnoozeThis
Copy link

The deadline passed while snoozing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@melink14 @SnoozeThis