Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit presubmit workflow for security problems #1415

Open
melink14 opened this issue Feb 13, 2023 · 0 comments
Open

Audit presubmit workflow for security problems #1415

melink14 opened this issue Feb 13, 2023 · 0 comments

Comments

@melink14
Copy link
Owner

It currently uses pull_request_target in an unsafe way so we should make sure there's nothing actually dangerous.

Secrets:

  • Default repo secret
  • Codecov secret

The first one only has contents: write permission and branch protections means it can't write to main?
Codecov would be able to mess up our coverage somehow but that would not be dangerous...

We could use https://dev.to/petrsvihlik/using-environment-protection-rules-to-secure-secrets-when-building-external-forks-with-pullrequesttarget-hci to require an approval before building unsafe code. This should be doable only on external PR requests but need to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant