New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: next version of ppxlib #10

Merged

anmonteiro merged 1 commit into master from anmonteiro/fix-next-ppxlib

Sep 21, 2023

Member

anmonteiro commented Sep 20, 2023

The next version of ppxlib enforces generative functor application, and produces errors in the cases changed in this PR
unfortunately Reason formats Foo({}) to Foo(), i.e. there seems to be no distinction between OCaml's Foo(struct end) and Foo()
- this will probably have to be fixed upstream
for now we use { (); } to force a single structure item


          fix: next version of ppxlib

ed9ea9a

jchavarri approved these changes

View reviewed changes

anmonteiro merged commit 1f53fc0 into master

1 check passed

anmonteiro deleted the anmonteiro/fix-next-ppxlib branch

September 21, 2023 17:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet