Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.30] Delete old and processed tasks #368

Closed
11 tasks
brunoocasali opened this issue Mar 4, 2023 · 0 comments · Fixed by #425
Closed
11 tasks

[v0.30] Delete old and processed tasks #368

brunoocasali opened this issue Mar 4, 2023 · 0 comments · Fixed by #425
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Mar 4, 2023

This feature request is part of the new set of features introduced on Meilisearch v0.30.
Extracted from meilisearch/integration-guides#221.

Related to:

This issue aims to reduce the users' friction with disk size management by allowing them to delete the old processed tasks.

  • A new endpoint: DELETE /tasks
  • A new task type: taskDeletion
  • Add deletedTasks in field details from Task type when performing taskDeletion
  • A new API key action: tasks.delete
  • Guarantee all the filters available in the GET /tasks but from and limit are available.
  • Add uids filter. e.g /tasks?uids=1,2,3,4 (⚠️ only effective after RC1)
    • error code in case of failure: invalid_task_uids_filter
  • Add canceledBy filter. e.g /tasks?canceledBy=99,100
    • error code in case of failure: invalid_task_canceled_by_filter
  • Add beforeEnqueuedAt and afterEnqueuedAt. e.g /tasks?afterEnqueuedAt=2022-01-20&beforeEnqueuedAt=2022-01-23
  • Add beforeStartedAt and afterStartedAt. e.g /tasks?afterStartedAt=2022-01-20&beforeStartedAt=2022-01-23
  • Add beforeFinishedAt and afterFinishedAt. e.g /tasks?afterFinishedAt=2022-01-20&beforeFinishedAt=2022-01-23
  • Add code delete_tasks_1 into this file
    This code sample should show an example of the corresponding curl command, but with swift code:
curl \
    -X DELETE 'http://localhost:7700/tasks?uids=1,2'

General recommendations to implement this issue:

  • Check the TasksQuery.swift as an example.
  • Make sure your DeleteTasksQuery class implements Queryable protocol.
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2023
@meili-bors meili-bors bot closed this as completed in 978cd07 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant