From 0429b85d467f0387cf804535425392d223dcc9dd Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Sat, 1 Oct 2022 23:25:50 +0530 Subject: [PATCH 01/14] Add support to the pagination setting customization at the index level --- .code-samples.meilisearch.yaml | 30 +++++++++++ src/settings.rs | 96 ++++++++++++++++++++++++++++++++++ 2 files changed, 126 insertions(+) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index d8560e46..f31118f1 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -220,6 +220,27 @@ reset_synonyms_1: |- .reset_synonyms() .await .unwrap(); +get_pagination_settings_1: |- + let pagination: HashMap = client + .index("movies") + .get_pagination() + .await + .unwrap(); +update_pagination_settings_1: |- + let mut pagination = std::collections::HashMap::new(); + pagination.insert(String::from("maxTotalHits"), 100); + + let task: TaskInfo = client + .index("movies") + .set_pagination(&pagination) + .await + .unwrap(); +reset_pagination_settings_1: |- + let task: TaskInfo = client + .index("movies") + .reset_pagination() + .await + .unwrap(); get_stop_words_1: |- let stop_words: Vec = client .index("movies") @@ -635,6 +656,15 @@ settings_guide_searchable_1: |- .set_settings(&settings) .await .unwrap(); +settings_guide_pagination_1: |- + let mut pagination = std::collections::HashMap::new(); + pagination.insert(String::from("maxTotalHits"), 100); + + let task: TaskInfo = client + .index("books") + .set_pagination(&pagination) + .await + .unwrap(); settings_guide_displayed_1: |- let settings = Settings::new() .with_displayed_attributes([ diff --git a/src/settings.rs b/src/settings.rs index e2f33da9..18106324 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -251,6 +251,35 @@ impl Index { .await } + /// Get [pagination](https://docs.meilisearch.com/learn/configuration/settings.html#pagination) of the [Index]. + /// + /// ``` + /// # use meilisearch_sdk::{client::*, indexes::*}; + /// # + /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); + /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); + /// # + /// # futures::executor::block_on(async move { + /// let client = Client::new(MEILISEARCH_HOST, MEILISEARCH_API_KEY); + /// # client.create_index("get_pagination", None).await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// let index = client.index("get_pagination"); + /// let pagination = index.get_pagination().await.unwrap(); + /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// # }); + /// ``` + pub async fn get_pagination(&self) -> Result, Error> { + request::<(), HashMap>( + &format!( + "{}/indexes/{}/settings/pagination", + self.client.host, self.uid + ), + &self.client.api_key, + Method::Get(()), + 200, + ) + .await + } + /// Get [stop-words](https://docs.meilisearch.com/reference/features/stop_words.html) of the [Index]. /// /// ``` @@ -528,6 +557,42 @@ impl Index { .await } + /// Update [pagination](https://docs.meilisearch.com/learn/configuration/settings.html#pagination) of the [Index]. + /// + /// # Example + /// + /// ``` + /// # use meilisearch_sdk::{client::*, indexes::*, settings::Settings}; + /// # + /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); + /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); + /// # + /// # futures::executor::block_on(async move { + /// let client = Client::new(MEILISEARCH_HOST, MEILISEARCH_API_KEY); + /// # client.create_index("set_pagination", None).await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// let mut index = client.index("set_pagination"); + /// let mut pagination = std::collections::HashMap::new(); + /// pagination.insert(String::from("maxTotalHits"), 100); + /// let task = index.set_pagination(&pagination).await.unwrap(); + /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// # }); + /// ``` + pub async fn set_pagination( + &self, + pagination: &HashMap, + ) -> Result { + request::<&HashMap, TaskInfo>( + &format!( + "{}/indexes/{}/settings/pagination", + self.client.host, self.uid + ), + &self.client.api_key, + Method::Patch(pagination), + 202, + ) + .await + } + /// Update [stop-words](https://docs.meilisearch.com/reference/features/stop_words.html) of the [Index]. /// /// # Example @@ -878,6 +943,37 @@ impl Index { .await } + /// Reset [pagination](https://docs.meilisearch.com/learn/configuration/settings.html#pagination) of the [Index]. + /// + /// # Example + /// + /// ``` + /// # use meilisearch_sdk::{client::*, indexes::*, settings::Settings}; + /// # + /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); + /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); + /// # + /// # futures::executor::block_on(async move { + /// let client = Client::new(MEILISEARCH_HOST, MEILISEARCH_API_KEY); + /// # client.create_index("reset_pagination", None).await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// let mut index = client.index("reset_pagination"); + /// + /// let task = index.reset_pagination().await.unwrap(); + /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); + /// # }); + /// ``` + pub async fn reset_pagination(&self) -> Result { + request::<(), TaskInfo>( + &format!( + "{}/indexes/{}/settings/pagination", + self.client.host, self.uid + ), + &self.client.api_key, + Method::Delete, + 202, + ) + .await + } /// Reset [stop-words](https://docs.meilisearch.com/reference/features/stop_words.html) of the [Index]. /// /// # Example From f960455134720e665af04068891d9e64af52490f Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Mon, 3 Oct 2022 18:37:51 +0530 Subject: [PATCH 02/14] create PaginationSetting struct --- src/settings.rs | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index 18106324..dc525627 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -6,7 +6,11 @@ use crate::{ }; use serde::{Deserialize, Serialize}; use std::collections::HashMap; - +#[derive(Serialize, Deserialize, Default, Debug, Clone)] +#[serde(rename_all = "camelCase")] +pub struct PaginationSetting { + pub max_total_hits: i32 +} /// Struct reprensenting a set of settings. /// You can build this struct using the builder syntax. /// @@ -562,7 +566,7 @@ impl Index { /// # Example /// /// ``` - /// # use meilisearch_sdk::{client::*, indexes::*, settings::Settings}; + /// # use meilisearch_sdk::{client::*, indexes::*, settings::{Settings, PaginationSetting}}; /// # /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); @@ -571,23 +575,22 @@ impl Index { /// let client = Client::new(MEILISEARCH_HOST, MEILISEARCH_API_KEY); /// # client.create_index("set_pagination", None).await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); /// let mut index = client.index("set_pagination"); - /// let mut pagination = std::collections::HashMap::new(); - /// pagination.insert(String::from("maxTotalHits"), 100); - /// let task = index.set_pagination(&pagination).await.unwrap(); + /// let pagination = PaginationSetting {max_total_hits:100}; + /// let task = index.set_pagination(pagination).await.unwrap(); /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); /// # }); /// ``` pub async fn set_pagination( &self, - pagination: &HashMap, + pagination: PaginationSetting, ) -> Result { - request::<&HashMap, TaskInfo>( + request::<&PaginationSetting, TaskInfo>( &format!( "{}/indexes/{}/settings/pagination", self.client.host, self.uid ), &self.client.api_key, - Method::Patch(pagination), + Method::Patch(&pagination), 202, ) .await From 012ad812f8e63524237633bb83c06148b9290421 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Mon, 3 Oct 2022 21:54:58 +0530 Subject: [PATCH 03/14] update the code to reflect usage of PaginationSetting structure --- .code-samples.meilisearch.yaml | 12 +++++------- src/settings.rs | 6 +++--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index f31118f1..a8e70f65 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -221,18 +221,17 @@ reset_synonyms_1: |- .await .unwrap(); get_pagination_settings_1: |- - let pagination: HashMap = client + let pagination: PaginationSetting = client .index("movies") .get_pagination() .await .unwrap(); update_pagination_settings_1: |- - let mut pagination = std::collections::HashMap::new(); - pagination.insert(String::from("maxTotalHits"), 100); + let pagination = PaginationSetting {max_total_hits:100}; let task: TaskInfo = client .index("movies") - .set_pagination(&pagination) + .set_pagination(pagination) .await .unwrap(); reset_pagination_settings_1: |- @@ -657,12 +656,11 @@ settings_guide_searchable_1: |- .await .unwrap(); settings_guide_pagination_1: |- - let mut pagination = std::collections::HashMap::new(); - pagination.insert(String::from("maxTotalHits"), 100); + let pagination = PaginationSetting {max_total_hits:100}; let task: TaskInfo = client .index("books") - .set_pagination(&pagination) + .set_pagination(pagination) .await .unwrap(); settings_guide_displayed_1: |- diff --git a/src/settings.rs b/src/settings.rs index dc525627..d137ced2 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -9,7 +9,7 @@ use std::collections::HashMap; #[derive(Serialize, Deserialize, Default, Debug, Clone)] #[serde(rename_all = "camelCase")] pub struct PaginationSetting { - pub max_total_hits: i32 + pub max_total_hits: u32 } /// Struct reprensenting a set of settings. /// You can build this struct using the builder syntax. @@ -271,8 +271,8 @@ impl Index { /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); /// # }); /// ``` - pub async fn get_pagination(&self) -> Result, Error> { - request::<(), HashMap>( + pub async fn get_pagination(&self) -> Result { + request::<(), PaginationSetting>( &format!( "{}/indexes/{}/settings/pagination", self.client.host, self.uid From 82b22f7f5deaa14afc8810634fe339bae55b93d5 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Tue, 4 Oct 2022 19:27:12 +0530 Subject: [PATCH 04/14] add pagination struct to settings structas member --- src/settings.rs | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index d137ced2..cef19038 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -62,6 +62,8 @@ pub struct Settings { /// Fields displayed in the returned documents #[serde(skip_serializing_if = "Option::is_none")] pub displayed_attributes: Option>, + #[serde(skip_serializing_if = "Option::is_none")] + pub pagination: Option, } #[allow(missing_docs)] @@ -77,6 +79,7 @@ impl Settings { distinct_attribute: None, searchable_attributes: None, displayed_attributes: None, + pagination: None } } pub fn with_synonyms(self, synonyms: HashMap) -> Settings @@ -116,6 +119,17 @@ impl Settings { } } + pub fn with_pagination( + self, + pagination_settings: PaginationSetting + ) -> Settings { + Settings { + pagination: Some( + pagination_settings), + ..self + } + } + pub fn with_ranking_rules( self, ranking_rules: impl IntoIterator>, @@ -493,7 +507,7 @@ impl Index { /// # Example /// /// ``` - /// # use meilisearch_sdk::{client::*, indexes::*, settings::Settings}; + /// # use meilisearch_sdk::{client::*, indexes::*, settings::{Settings,PaginationSetting}}; /// # /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); @@ -505,7 +519,9 @@ impl Index { /// /// let stop_words = vec![String::from("a"), String::from("the"), String::from("of")]; /// let settings = Settings::new() - /// .with_stop_words(stop_words.clone()); + /// .with_stop_words(stop_words.clone()) + /// .with_pagination(PaginationSetting {max_total_hits: 100} + /// ); /// /// let task = index.set_settings(&settings).await.unwrap(); /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); From dbba176d4637c30771e20e47a14f4f4138ca42b8 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Tue, 4 Oct 2022 20:51:25 +0530 Subject: [PATCH 05/14] fix styling issues --- src/settings.rs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index cef19038..4bc50839 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -79,7 +79,7 @@ impl Settings { distinct_attribute: None, searchable_attributes: None, displayed_attributes: None, - pagination: None + pagination: None, } } pub fn with_synonyms(self, synonyms: HashMap) -> Settings @@ -119,13 +119,9 @@ impl Settings { } } - pub fn with_pagination( - self, - pagination_settings: PaginationSetting - ) -> Settings { + pub fn with_pagination(self, pagination_settings: PaginationSetting) -> Settings { Settings { - pagination: Some( - pagination_settings), + pagination: Some(pagination_settings), ..self } } @@ -596,10 +592,7 @@ impl Index { /// # index.delete().await.unwrap().wait_for_completion(&client, None, None).await.unwrap(); /// # }); /// ``` - pub async fn set_pagination( - &self, - pagination: PaginationSetting, - ) -> Result { + pub async fn set_pagination(&self, pagination: PaginationSetting,) -> Result { request::<&PaginationSetting, TaskInfo>( &format!( "{}/indexes/{}/settings/pagination", From 262443a430e55199d9a1284000e3857791260d85 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Tue, 4 Oct 2022 21:50:45 +0530 Subject: [PATCH 06/14] add 3 tests for pagination settings --- src/settings.rs | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/src/settings.rs b/src/settings.rs index 4bc50839..d784529d 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -6,7 +6,7 @@ use crate::{ }; use serde::{Deserialize, Serialize}; use std::collections::HashMap; -#[derive(Serialize, Deserialize, Default, Debug, Clone)] +#[derive(Serialize, Deserialize, Default, Debug, Clone, PartialEq, Copy)] #[serde(rename_all = "camelCase")] pub struct PaginationSetting { pub max_total_hits: u32 @@ -1211,3 +1211,49 @@ impl Index { .await } } + +#[cfg(test)] +mod tests { + use super::*; + + use crate::client::*; + use meilisearch_test_macro::meilisearch_test; + + #[meilisearch_test] + async fn test_get_pagination(index: Index) { + let res = index.get_pagination().await.unwrap(); + let pagination = PaginationSetting { + max_total_hits: 1000, + }; + + assert_eq!(pagination, res); + } + + #[meilisearch_test] + async fn test_set_pagination(index: Index) { + let pagination = PaginationSetting { + max_total_hits: 11, + }; + let task = index.set_pagination(pagination).await.unwrap(); + index.wait_for_task(task, None, None).await.unwrap(); + let res = index.get_pagination().await.unwrap(); + + assert_eq!(pagination, res); + } + + #[meilisearch_test] + async fn test_reset_pagination(index: Index) { + let pagination = PaginationSetting { + max_total_hits: 10, + }; + let task = index.set_pagination(pagination).await.unwrap(); + index.wait_for_task(task, None, None).await.unwrap(); + let reset_task = index.reset_pagination().await.unwrap(); + index.wait_for_task(reset_task, None, None).await.unwrap(); + let res = index.get_pagination().await.unwrap(); + + let default = PaginationSetting { max_total_hits: 1000}; + + assert_eq!(default, res); + } +} \ No newline at end of file From 666e5733783bafeb8e44f4ac8e1f904f33d7de4d Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Tue, 4 Oct 2022 21:57:53 +0530 Subject: [PATCH 07/14] fix clippy warning for Eq --- src/settings.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings.rs b/src/settings.rs index d784529d..4354d174 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -6,7 +6,7 @@ use crate::{ }; use serde::{Deserialize, Serialize}; use std::collections::HashMap; -#[derive(Serialize, Deserialize, Default, Debug, Clone, PartialEq, Copy)] +#[derive(Serialize, Deserialize, Default, Debug, Clone, PartialEq, Eq, Copy)] #[serde(rename_all = "camelCase")] pub struct PaginationSetting { pub max_total_hits: u32 From e05e76f73617bfb1a340d59883d81318d3cb5abe Mon Sep 17 00:00:00 2001 From: Vishal Sodani Date: Wed, 5 Oct 2022 19:58:20 +0530 Subject: [PATCH 08/14] Make property as usize Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> --- src/settings.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings.rs b/src/settings.rs index 4354d174..462c7194 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -9,7 +9,7 @@ use std::collections::HashMap; #[derive(Serialize, Deserialize, Default, Debug, Clone, PartialEq, Eq, Copy)] #[serde(rename_all = "camelCase")] pub struct PaginationSetting { - pub max_total_hits: u32 + pub max_total_hits: usize } /// Struct reprensenting a set of settings. /// You can build this struct using the builder syntax. From dccbfc8479312c0ef3c3ce2ae49f8cff03b2bed9 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Wed, 5 Oct 2022 20:06:28 +0530 Subject: [PATCH 09/14] fix code samples --- .code-samples.meilisearch.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index a8e70f65..1542988b 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -222,7 +222,7 @@ reset_synonyms_1: |- .unwrap(); get_pagination_settings_1: |- let pagination: PaginationSetting = client - .index("movies") + .index("books") .get_pagination() .await .unwrap(); @@ -230,13 +230,13 @@ update_pagination_settings_1: |- let pagination = PaginationSetting {max_total_hits:100}; let task: TaskInfo = client - .index("movies") + .index("books") .set_pagination(pagination) .await .unwrap(); reset_pagination_settings_1: |- let task: TaskInfo = client - .index("movies") + .index("books") .reset_pagination() .await .unwrap(); @@ -659,7 +659,7 @@ settings_guide_pagination_1: |- let pagination = PaginationSetting {max_total_hits:100}; let task: TaskInfo = client - .index("books") + .index("movies") .set_pagination(pagination) .await .unwrap(); From 58ea450010c03ad50bbf818a274d5b04177ae090 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Wed, 5 Oct 2022 20:09:38 +0530 Subject: [PATCH 10/14] fix styling issues --- src/settings.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index 462c7194..9f2714ef 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -1222,6 +1222,7 @@ mod tests { #[meilisearch_test] async fn test_get_pagination(index: Index) { let res = index.get_pagination().await.unwrap(); + let pagination = PaginationSetting { max_total_hits: 1000, }; @@ -1236,6 +1237,7 @@ mod tests { }; let task = index.set_pagination(pagination).await.unwrap(); index.wait_for_task(task, None, None).await.unwrap(); + let res = index.get_pagination().await.unwrap(); assert_eq!(pagination, res); @@ -1246,14 +1248,16 @@ mod tests { let pagination = PaginationSetting { max_total_hits: 10, }; + let default = PaginationSetting { max_total_hits: 1000}; + let task = index.set_pagination(pagination).await.unwrap(); index.wait_for_task(task, None, None).await.unwrap(); + let reset_task = index.reset_pagination().await.unwrap(); index.wait_for_task(reset_task, None, None).await.unwrap(); + let res = index.get_pagination().await.unwrap(); - let default = PaginationSetting { max_total_hits: 1000}; - assert_eq!(default, res); } -} \ No newline at end of file +} From 53c5da805217a7f0216f3047376edcb6b5d0c061 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Thu, 6 Oct 2022 19:52:05 +0530 Subject: [PATCH 11/14] add comment for pagination property --- src/settings.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/settings.rs b/src/settings.rs index 6aed4a51..b6dc5e97 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -71,6 +71,7 @@ pub struct Settings { /// Fields displayed in the returned documents #[serde(skip_serializing_if = "Option::is_none")] pub displayed_attributes: Option>, + /// Pagination settings #[serde(skip_serializing_if = "Option::is_none")] pub pagination: Option, /// Faceting settings From 82d9fec60c09dd1bd90a94feeb612df4a345a831 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Thu, 6 Oct 2022 20:00:26 +0530 Subject: [PATCH 12/14] removed duplicate declaration of test --- src/settings.rs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index b6dc5e97..dbecd700 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -1396,14 +1396,6 @@ mod tests { assert_eq!(faceting, res); } -} - -#[cfg(test)] -mod tests { - use super::*; - - use crate::client::*; - use meilisearch_test_macro::meilisearch_test; #[meilisearch_test] async fn test_get_pagination(index: Index) { From 98e9ceedcca8f44d57ec19ecb3f960a4f528af4b Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Thu, 6 Oct 2022 20:03:46 +0530 Subject: [PATCH 13/14] fix code styling issues --- src/settings.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/settings.rs b/src/settings.rs index dbecd700..f2a5e20b 100644 --- a/src/settings.rs +++ b/src/settings.rs @@ -556,7 +556,7 @@ impl Index { /// # Example /// /// ``` - /// # use meilisearch_sdk::{client::*, indexes::*, settings::{Settings,PaginationSetting}}; + /// # use meilisearch_sdk::{client::*, indexes::*, settings::{Settings, PaginationSetting}}; /// # /// # let MEILISEARCH_HOST = option_env!("MEILISEARCH_HOST").unwrap_or("http://localhost:7700"); /// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey"); @@ -1399,12 +1399,12 @@ mod tests { #[meilisearch_test] async fn test_get_pagination(index: Index) { - let res = index.get_pagination().await.unwrap(); - let pagination = PaginationSetting { max_total_hits: 1000, }; + let res = index.get_pagination().await.unwrap(); + assert_eq!(pagination, res); } From 2c267acf7f620da0ddc91ee702e86e2f9ab75323 Mon Sep 17 00:00:00 2001 From: vishalsodani Date: Fri, 7 Oct 2022 00:14:02 +0530 Subject: [PATCH 14/14] add Box as per clippys suggestion --- src/tasks.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tasks.rs b/src/tasks.rs index 45418631..bf971d27 100644 --- a/src/tasks.rs +++ b/src/tasks.rs @@ -26,7 +26,7 @@ pub enum TaskType { details: Option, }, SettingsUpdate { - details: Option, + details: Box>, }, DumpCreation { details: Option,