Improve testing on document deletion with a filter

Author: bidoubiwa

src/documents.rs

@@ -420,21 +420,17 @@ mod tests {
         setup_test_index(&client, &index).await?;
         index
             .set_filterable_attributes(["id"])
-            .await
-            .unwrap()
+            .await?
             .wait_for_completion(&client, None, None)
-            .await
-            .unwrap();
+            .await?;
+
         let mut query = DocumentDeletionQuery::new(&index);
         query.with_filter("id = 1");
-
         index
             .delete_documents_with(&query)
-            .await
-            .unwrap()
+            .await?
             .wait_for_completion(&client, None, None)
-            .await
-            .unwrap();
+            .await?;
         let document_result = index.get_document::<MyObject>("1").await;
 
         match document_result {
@@ -450,6 +446,62 @@ mod tests {
         Ok(())
     }
 
+    #[meilisearch_test]
+    async fn test_delete_documents_with_no_filter(
+        client: Client,
+        index: Index,
+    ) -> Result<(), Error> {
+        setup_test_index(&client, &index).await?;
+        index
+            .set_filterable_attributes(["id"])
+            .await?
+            .wait_for_completion(&client, None, None)
+            .await?;
+
+        let query = DocumentDeletionQuery::new(&index);
+        let error = index.delete_documents_with(&query).await.unwrap_err();
+
+        assert!(matches!(
+            error,
+            Error::Meilisearch(MeilisearchError {
+                error_code: ErrorCode::InvalidDocumentDeleteFilter,
+                error_type: ErrorType::InvalidRequest,
+                ..
+            })
+        ));
+
+        Ok(())
+    }
+
+    #[meilisearch_test]
+    async fn test_delete_documents_with_filter_not_filterable(
+        client: Client,
+        index: Index,
+    ) -> Result<(), Error> {
+        setup_test_index(&client, &index).await?;
+
+        let mut query = DocumentDeletionQuery::new(&index);
+        query.with_filter("id = 1");
+        let error = index
+            .delete_documents_with(&query)
+            .await?
+            .wait_for_completion(&client, None, None)
+            .await?;
+
+        let error = error.unwrap_failure();
+
+        assert!(matches!(
+            error,
+            MeilisearchError {
+                error_code: ErrorCode::InvalidDocumentDeleteFilter,
+                error_type: ErrorType::InvalidRequest,
+                ..
+            }
+        ));
+
+        Ok(())
+    }
+
     #[meilisearch_test]
     async fn test_get_documents_with_only_one_param(
         client: Client,

src/errors.rs

@@ -131,6 +131,7 @@ pub enum ErrorCode {
     MaxFieldsLimitExceeded,
     MissingDocumentId,
     InvalidDocumentId,
+    InvalidDocumentDeleteFilter,
     BadParameter,
     BadRequest,
     DatabaseSizeLimitReached,