Skip to content

Conversation

@norkunas
Copy link
Collaborator

@norkunas norkunas commented Dec 1, 2025

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Fixes PHP-CS-Fixer deprecation by using new config option instead of deprecated environment variable

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Summary by CodeRabbit

  • Chores
    • Updated development tooling and continuous integration configurations to improve build and code quality processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

Two PHP Code Sniffer configuration files were modified: an environment variable PHP_CS_FIXER_IGNORE_ENV: 1 was removed from the GitHub Actions lint workflow, and setUnsupportedPhpVersionAllowed(true) was added to the .php-cs-fixer.dist.php configuration chain.

Changes

Cohort / File(s) Summary
PHP CS Fixer Configuration
\\.github/workflows/tests.yml, \.php-cs-fixer.dist.php
Removed environment variable PHP_CS_FIXER_IGNORE_ENV: 1 from the lint job and added setUnsupportedPhpVersionAllowed(true) to the config chain to enable processing with unsupported PHP versions

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Configuration changes with straightforward edits across two files
  • The removal of an environment variable is direct, but verify the related configuration addition functions as intended in the lint workflow

Poem

🐰 Hops with glee through config files so neat,
Environment checks now face retreat,
Unsupported versions? No need to fight,
PHP fixer now processes just right!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix PHP-CS-Fixer deprecation' directly and accurately reflects the main change: removing a deprecated environment variable and adding a new configuration option to address a PHP-CS-Fixer deprecation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 565bca2 and b97bd1d.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml (0 hunks)
  • .php-cs-fixer.dist.php (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/tests.yml
🔇 Additional comments (1)
.php-cs-fixer.dist.php (1)

10-22: Config-level replacement for PHP_CS_FIXER_IGNORE_ENV looks correct

Using setUnsupportedPhpVersionAllowed(true) in the config chain is the intended way to replace the deprecated PHP_CS_FIXER_IGNORE_ENV workaround, and it fits cleanly here with the other config calls. Please just double‑check that your php-cs-fixer version supports this method and that there are no remaining uses of PHP_CS_FIXER_IGNORE_ENV in other CI scripts or local tooling docs.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (0078a8c) to head (b97bd1d).
⚠️ Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   89.78%   88.02%   -1.76%     
==========================================
  Files          59       81      +22     
  Lines        1449     1729     +280     
==========================================
+ Hits         1301     1522     +221     
- Misses        148      207      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@norkunas norkunas enabled auto-merge December 1, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant