Skip to content

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Nov 3, 2025

why

We want tests to be triggered when PRs targeting v1.x are sent to the merge queue.

how

This PR adds the merge_group trigger to the tests workflow to ensure GitHub Merge Queue can run required checks when using the merge queue with the v1.x branch.

Reference: GitHub Actions merge_group event

Summary by CodeRabbit

  • Chores
    • Enhanced GitHub Actions workflow configuration to execute tests when merge checks are requested, improving merge validation reliability and ensuring comprehensive test coverage during the merge process.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

The pull request adds a merge_group trigger to the GitHub Actions workflow configuration, enabling automated test runs when merge queue checks are requested for a pull request.

Changes

Cohort / File(s) Summary
CI/CD workflow configuration
.github/workflows/tests.yml
Added merge_group event trigger to the workflow's on: section to support GitHub's merge queue feature for automated checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • curquiza
  • brunoocasali

Poem

🐰 A queue of PRs, now merging with grace,
The merge_group trigger sets the pace,
No more delays in the CI's embrace,
Workflows run swift in their appointed place! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Add merge_group trigger to workflows for merge queue' directly and clearly describes the main change in the changeset. The raw summary confirms that the modification adds a new merge_group trigger to the GitHub Actions workflow, which is exactly what the title conveys. The title is specific, concise, and accurately reflects the primary objective of enabling tests to run when PRs are sent to the GitHub Merge Queue.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add/merge_group-to-v1.x-tests

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9f63e0 and f6391d9.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/tests.yml (1)

13-14: Correct implementation of merge queue trigger.

The addition of the merge_group trigger with types: [checks_requested] is the standard and recommended way to enable GitHub Merge Queue support. This allows the workflow to run required checks when PRs are added to the merge queue.

The conditional on line 72 will handle merge_group events correctly since github.event_name will not equal 'pull_request', ensuring the tests run in the merge queue context.

Please verify that github.base_ref is reliably available in the merge_group context for the conditional on line 72. You can test this by merging the PR and monitoring a merge queue run to ensure the condition evaluates as expected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 3, 2025
@norkunas
Copy link
Collaborator

norkunas commented Nov 3, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Strift Strift added this pull request to the merge queue Nov 4, 2025
@Strift Strift merged commit ca08ad7 into v1.x Nov 4, 2025
11 checks passed
@Strift Strift deleted the add/merge_group-to-v1.x-tests branch November 4, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants