Skip to content

Commit 9a27e63

Browse files
committed
Umd works in node and browser, removes cjs from repo
1 parent 681ccb7 commit 9a27e63

File tree

5 files changed

+8
-20
lines changed

5 files changed

+8
-20
lines changed

examples/browser/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div id="indexes"></div>
1212
</body>
1313
</html>
14-
<script src="../../dist/bundles/meilisearch.browser.js"></script>
14+
<script src="../../dist/bundles/meilisearch.umd.js"></script>
1515
<script>
1616
const client = new window.MeiliSearch({
1717
host: 'http://127.0.0.1:7700',

examples/node/search_example.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const MeiliSearch = require('../../dist/bundles/meilisearch.cjs.js')
1+
const MeiliSearch = require('../../dist/bundles/meilisearch.umd.js')
22
const dataset = require('./small_movies.json')
33

44
const config = {

examples/node/small_index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const MeiliSearch = require('../../dist/bundles/meilisearch.cjs.js')
1+
const MeiliSearch = require('../../dist/bundles/meilisearch.umd.js')
22

33
const config = {
44
host: 'http://127.0.0.1:7700',

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
"qdequele <[email protected]>"
1717
],
1818
"license": "MIT",
19-
"main": "./dist/bundles/meilisearch.cjs.js",
19+
"main": "./dist/bundles/meilisearch.umd.js",
2020
"module": "./dist/bundles/meilisearch.esm.js",
21-
"browser": "./dist/bundles/meilisearch.browser.js",
21+
"browser": "./dist/bundles/meilisearch.umd.js",
2222
"typings": "./dist/types/types.d.ts",
2323
"types": "./dist/types/types.d.ts",
2424
"jsnext:main": "./dist/bundles/meilisearch.esm.js",
@@ -36,7 +36,7 @@
3636
"test:watch": "yarn test --watch",
3737
"test:coverage": "yarn test --coverage",
3838
"test:ci": "yarn test --ci",
39-
"size": "node scripts/file-size ./dist/bundles/meilisearch.cjs.min.js ./dist/bundles/meilisearch.esm.min.js ./dist/bundles/meilisearch.browser.min.js",
39+
"size": "node scripts/file-size ./dist/bundles/meilisearch.esm.min.js ./dist/bundles/meilisearch.umd.min.js",
4040
"style": "yarn lint",
4141
"style:fix": "yarn lint:fix",
4242
"lint": "eslint --ext .js,.ts,.tsx .",

rollup.config.js

+2-14
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ const PLUGINS = [
2828
]
2929

3030
module.exports = [
31-
// browser-friendly IIFE build
31+
// browser-friendly UMD build
3232
{
3333
input: 'src/meilisearch.ts', // directory to transpilation of typescript
34+
external: ['cross-fetch', 'cross-fetch/polyfill'],
3435
output: {
3536
name: LIB_NAME,
3637
file: getOutputFileName(
@@ -40,9 +41,6 @@ module.exports = [
4041
),
4142
format: 'umd',
4243
sourcemap: env === 'production', // create sourcemap for error reporting in production mode
43-
globals: {
44-
fetch: 'cross-fetch',
45-
},
4644
},
4745
plugins: [
4846
...PLUGINS,
@@ -85,16 +83,6 @@ module.exports = [
8583
input: 'src/meilisearch.ts',
8684
external: ['cross-fetch', 'cross-fetch/polyfill'],
8785
output: [
88-
{
89-
file: getOutputFileName(
90-
// will add .min. in filename if in production env
91-
resolve(ROOT, pkg.main),
92-
env === 'production'
93-
),
94-
exports: 'default',
95-
format: 'cjs',
96-
sourcemap: env === 'production', // create sourcemap for error reporting in production mode
97-
},
9886
{
9987
file: getOutputFileName(
10088
resolve(ROOT, pkg.module),

0 commit comments

Comments
 (0)