Update types

Author: bidoubiwa

.eslintrc.js

@@ -2,6 +2,7 @@ module.exports = {
   env: {
     browser: true,
     es6: true,
+    es2020: true,
     'jest/globals': true,
     node: true,
   },
@@ -14,7 +15,7 @@ module.exports = {
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 2019,
     project: ['tsconfig.eslint.json'],
     sourceType: 'module',
     projectFolderIgnoreList: ['dist'],

src/index.ts

@@ -76,7 +76,7 @@ class Index<T> extends MeiliAxiosWrapper implements Types.IndexInterface<T> {
   async search<P extends Types.SearchParams<T>>(
     query?: string,
     options?: P,
-    method: 'POST' | 'GET' = 'POST'
+    method: Types.Methods = 'POST'
   ): Promise<Types.SearchResponse<T, P>> {
     const url = `/indexes/${this.uid}/search`
     const params: Types.SearchRequest = {

src/types.ts

@@ -290,14 +290,16 @@ export interface MeiliSearchInterface extends MeiliAxiosWrapper {
   prettySysInfo: () => Promise<SysInfoPretty>
 }
 
+export type Methods = 'POST' | 'GET'
+
 export interface IndexInterface<T = any> extends MeiliAxiosWrapperInterface {
   uid: string
   getUpdateStatus: (updateId: number) => Promise<Update>
   getAllUpdateStatus: () => Promise<Update[]>
   search: <P extends SearchParams<T>>(
     query: string,
     options?: P,
-    method?: 'POST' | 'GET'
+    method?: Methods
   ) => Promise<SearchResponse<T, P>>
   show: () => Promise<IndexResponse>
   updateIndex: (indexData: IndexOptions) => Promise<IndexResponse>

src/utils.ts

@@ -1,10 +1,7 @@
-function removeUndefinedFromObject(object: Record<string, any>): object {
-  return Object.keys(object).reduce((acc: Record<string, any>, key: string) => {
-    if (object[key] !== undefined) {
-      acc[key] = object[key]
-    }
-    return acc
-  }, {})
+function removeUndefinedFromObject(obj: object): object {
+  // remove undefined
+  const cleaned = Object.entries(obj).filter((x) => x[1] !== undefined)
+  return Object.fromEntries(cleaned)
 }
 
 async function sleep(ms: number): Promise<void> {