Skip to content

Conversation

@meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Feb 20, 2023

This version makes this package compatible with Meilisearch v0.30.0 🎉
Check out the changelog of Meilisearch v0.30.0 for more information on the changes(#382).

⚠️ Breaking changes

  • Add a builder for SearchRequest class (Add a builder for SearchRequest class #543) @alallema
    • The search method can now only be instantiated:
       SearchResult search(String q)
       Searchable search(SearchRequest searchRequest)
  • Parameters on getTasks name changes: The total number of paginated results is wrong #390
    • status -> statuses
    • indexUID -> indexUIDS
    • type -> types
  • New pagination strategy with the search parameters page and hitsPerPage Add pagination feature for v0.30.0 #546
    • public Searchable search(SearchRequest searchRequest) method now return Searchable which can be extended to two different classes of results SearchResult and SearchResultPaginated
    • SearchResult is now an extended class of Searchable
    • Creation of the SearchResultPaginated class to handle pagination results from search
    • Creation of a common search result class Searchable

🚀 Enhancements

🐛 Bug Fixes

Thanks again to @alallema, @gpor0 and @oraliahdz! 🎉

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Feb 20, 2023
@brunoocasali
Copy link
Member

Oh là là là là!

@brunoocasali
Copy link
Member

@alallema, just check the namings they are not following the java pattern. Like GetTasks is only getTasks. IndexUID is indexUids and others...

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@bors bors bot merged commit 85d33fd into main Feb 27, 2023
@bors bors bot deleted the meili-bot/bump-version branch February 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Http client gets initialized with GsonJsonHandler instead of configured customJsonHandler

4 participants