Add methods to automatically add/update documents in batches #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrocq
changed the title
Member
|
Hello @alejandrocq thanks a lot for your PR |
curquiza
requested changes
Oct 13, 2021
3 tasks
Contributor
Author
Sure! I missed those. I will fix them. |
alejandrocq
force-pushed
the
feature/#157
branch
from
45b69e4 to
fe96bd8
Compare
alejandrocq
force-pushed
the
feature/#157
branch
from
fe96bd8 to
571497e
Compare
Contributor
Author
|
Ok, I think all it's alright now, at least build and test look good in my machine :) |
curquiza
approved these changes
Oct 14, 2021
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
Thank you @alejandrocq
bors merge
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.
bors bot
added a commit
that referenced
this pull request
Oct 14, 2021
166: Add methods to automatically add/update documents in batches r=curquiza a=alejandrocq Hi, I have added the methods to add/update documents in batches (#157) in `Index.cs`. I have not been able to run the tests correctly because I get the following error in most of them: ``` Meilisearch.MeilisearchApiError MeilisearchApiError, Message: The Content-Type "application/json; charset=utf-8" is invalid. Accepted values for the Content-Type header are: "application/json", "application/x-ndjson", "application/csv" ``` Seems to be an error with the `PostJsonAsync`method adding the charset parameter, but I suppose that has been working correctly for you. Let me know if the code is okay and what should I do to fix that error. I will keep investigating if I get some time. Co-authored-by: Alejandro Castilla Quesada <[email protected]>
Contributor
|
Build failed: |
Member
|
bors try |
Contributor
tryBuild succeeded: |
Member
|
oops looks like there are some flaky, I will open an issue (it's because of the dumps, so not related to your PR) |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the methods to add/update documents in batches (#157) in
Index.cs. I have not been able to run the tests correctly because I get the following error in most of them:Seems to be an error with the
PostJsonAsyncmethod adding the charset parameter, but I suppose that has been working correctly for you.Let me know if the code is okay and what should I do to fix that error. I will keep investigating if I get some time.