-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Everything is pretty slow #317
Comments
Hello @irevoire 👋 Thanks a lot for opening this issue.
I'm not sure I understood correctly what you mean, but we are retrieving the entire document because we need all its fields to display them inside the modal: Therefore, we cannot request just a few fields because we need all of them 🥲 Regarding the highlighting, it's totally normal and it's voluntary not to display it, so I will remove this setting as you suggest 👍 |
Oh, ok, I missed this page; I guess the sensible thing to do would be to only query these data when someone clicks on a movie with the Feel free to close if you don't have the time to look into it. |
Thanks a lot @irevoire 🙏 I considered doing this, but this would mean having 2 meilisearch clients to do so:
This is completely feasible (I've done it before on the I'll close this issue (but thanks again for your time investigating and opening this issue!) as I don't really know if this is something we really want to implement and as I don't have the time to dig it now, but we could definitely discuss it again in the future |
If it is slow don't we lose a bit of the purpose of this demo? Since we want to showcase above anything else the speed and relevancy of Meilisearch, if we show slowness it might give the user the idea that we are only relevant but that we are not a fast search engine. |
That makes sense, I'll reopen this issue then, but I don't know when I'll have time to work on it 😃 |
Description
![image](https://user-images.githubusercontent.com/7032172/186477051-6ab6237e-e257-4c0c-9cef-c5e1cda29be8.png)
Hello, I was trying out this super cool demo and noticed everything was pretty slow.
As you can see most requests took ~100ms to get to me, while meilisearch was usually able to answer in ~5ms.
From what I see the reason is pretty simple, we're retrieving the entire document when we only need its title and poster.
This means we're downloading 120ko when we actually only need a few ko of data 😒
I guess the fix is pretty simple, you should send a search request that looks like this;
Also, I don't know if it's normal but I can't see the highlighting on my computer, thus maybe we could just remove the
attributesToHighlight
entirely.The text was updated successfully, but these errors were encountered: