Merge branch 'hotfix/SDK-4965_repair_corrupt_jscd_user_attribute' into 'release/v9.0.0'

SDK-4965. Repair corrupt "jscd" user's attribute (hotfix for v9.0.0)

See merge request sdk/sdk!6396

Author: sergiohs84

examples/megacli.cpp

@@ -1407,7 +1407,7 @@ void DemoApp::getua_result(unique_ptr<string_map> records, attr_t type)
 {
     if (!records)
     {
-        cout << "Error getting private user attribute" << endl;
+        cout << "Error getting private user attribute: No valid records in the attribute" << endl;
     }
     else if (!gVerboseMode)
     {

include/mega/types.h

@@ -876,6 +876,7 @@ typedef enum {
     REASON_ERROR_DB_FULL            = 3,
     REASON_ERROR_DB_INDEX_OVERFLOW  = 4,
     REASON_ERROR_NO_JSCD = 5,
+    REASON_ERROR_REGENERATE_JSCD = 6,
 } ErrorReason;
 
 //#define MEGA_MEASURE_CODE   // uncomment this to track time spent in major subsystems, and log it every 2 minutes, with extra control from megacli

include/megaapi.h

@@ -5857,6 +5857,7 @@ class MegaEvent
         REASON_ERROR_DB_FULL                    = 3,    // Failure at DB layer because disk is full
         REASON_ERROR_DB_INDEX_OVERFLOW          = 4,    // Index used to primary key at db overflow
         REASON_ERROR_NO_JSCD = 5, // No JSON Sync Config Data
+        REASON_ERROR_REGENERATE_JSCD = 6, // JSON Sync Config Data has been regenerated
     };
 
     virtual ~MegaEvent();
@@ -5906,6 +5907,7 @@ class MegaEvent
      *  - REASON_ERROR_DB_FULL = 3 -> Failure at DB layer because disk is full
      *  - REASON_ERROR_DB_INDEX_OVERFLOW = 4 -> Index used to primary key at db overflow
      *  - REASON_ERROR_NO_JSCD = 5 -> No JSON Sync Config Data
+     *  - REASON_ERROR_REGENERATE_JSCD = 6 -> JSON Sync Config Data has been regenerated
      *
      * @return Number relative to this event
      */

src/commands.cpp

@@ -3778,10 +3778,19 @@ bool CommandGetUA::procresult(Result r, JSON& json)
                             {
                                 LOG_err << "Cannot extract TLV records for private attribute "
                                         << User::attr2string(at);
-                                mCompletionErr(API_EINTERNAL);
+                                if (at == ATTR_JSON_SYNC_CONFIG_DATA)
+                                {
+                                    // Store the attribute so we can update it later with valid
+                                    // values
+                                    u->setAttribute(at, value, version);
+                                    mCompletionErr(API_EKEY);
+                                }
+                                else
+                                {
+                                    mCompletionErr(API_EINTERNAL);
+                                }
                                 return true;
                             }
-
                             break;
                         }
                         case ATTR_SCOPE_PUBLIC_UNENCRYPTED:
@@ -4237,7 +4246,7 @@ bool CommandGetUserData::updatePrivateEncryptedUserAttribute(User* u,
         }
         else
         {
-            LOG_err << "Cannot extract TLV records for " << at;
+            LOG_err << "Cannot extract TLV records for " << User::attr2string(at);
         }
     }
     else

src/megaclient.cpp

@@ -15279,10 +15279,11 @@ void MegaClient::fatalError(ErrorReason errorReason)
     mLastErrorDetected = errorReason;
 
     // Disable sync.
-    // Sync is not enabled in case of ErrorReason::REASON_ERROR_NO_JSCD,
-    // therefore no need to disable it.
+    // Sync is not enabled in case of ErrorReason::REASON_ERROR_NO_JSCD or
+    // ErrorReason::REASON_ERROR_REGENERATE_JSCD therefore no need to disable it.
 #ifdef ENABLE_SYNC
-    if (errorReason != ErrorReason::REASON_ERROR_NO_JSCD)
+    if (errorReason != ErrorReason::REASON_ERROR_NO_JSCD &&
+        errorReason != ErrorReason::REASON_ERROR_REGENERATE_JSCD)
     {
         syncs.disableSyncs(FAILURE_ACCESSING_PERSISTENT_STORAGE, false, true);
     }
@@ -15312,6 +15313,10 @@ void MegaClient::fatalError(ErrorReason errorReason)
             reason = "Failed to get JSON SYNC configuration data";
             sendevent(99488, reason.c_str(), 0);
             break;
+        case ErrorReason::REASON_ERROR_REGENERATE_JSCD:
+            reason = "Fix JSON SYNC configuration data";
+            sendevent(99489, reason.c_str(), 0);
+            break;
         case ErrorReason::REASON_ERROR_UNKNOWN:
             reason = "Unknown fatal error";
             sendevent(99489, reason.c_str(), 0);
@@ -23867,9 +23872,17 @@ void MegaClient::JSCDataRetrieved(GetJSCDataCallback& callback,
     // Sanity.
     assert(callback);
 
-    // The user doesn't have any JSC data.
-    if (result == API_ENOENT)
+    // The user doesn't have any JSC data or the attribute can't be decrypted or the attribute
+    // exists but is fully empty. In any case, create a new one.
+    if (result == API_ENOENT || result == API_EKEY || (result == API_OK && !store))
     {
+        if (result != API_ENOENT)
+        {
+            LOG_err << "Couldn't extract JSON SYNC configuration data. Automatically regenerating "
+                       "the attribute";
+            // Send an event and notify the app. Existing syncs (if any) have been removed.
+            fatalError(ErrorReason::REASON_ERROR_REGENERATE_JSCD);
+        }
         return createJSCData(std::move(callback));
     }