allow manual toggle of tooltip #629
Merged
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikodin
approved these changes
Sep 4, 2018
| if (nextProps.manualToggle && prevState.isActive !== nextProps.isActive) { | ||
| return { isActive: nextProps.isActive }; | ||
| } | ||
| return prevState; |
There was a problem hiding this comment.
yes, but this way imo is more explicit of what it is actually doing 😄
There was a problem hiding this comment.
No doubt, cool with me 🗻 . Just wanted to be sure haha
There was a problem hiding this comment.
Interesting. I disagree though, see here and comments related: reactjs/rfcs#26 (comment) "Returning null is slightly more performant (since React won't have to merge the state with itself). It also more clearly signals the intent of not updating anything."
There was a problem hiding this comment.
changing in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes https://meetup.atlassian.net/browse/MG-2364
Description
Accidentally removed the ability to click on the x in the tooltip to close it. This adds it back and allows the ability to close the tooltip by clicking outside of it.