Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch metadata again after download task times out #647

Open
tcely opened this issue Jan 25, 2025 · 4 comments
Open

Fetch metadata again after download task times out #647

tcely opened this issue Jan 25, 2025 · 4 comments

Comments

@tcely
Copy link
Contributor

tcely commented Jan 25, 2025

For #188, and other "disappearing formats" problems, it would be great if the metadata was pulled again by the software instead of the user skipping/unskipping media items.

I think we should be careful to preserve the existing metadata during this process because the video might have been deleted, and I want to still have the metadata in those cases.

@meeb
Copy link
Owner

meeb commented Jan 25, 2025

A simple hack for this might be a timed task that scans for "is downloadable = false" media items updated 12 hours or so hours ago and deletes then re-queues metadata collection for it. This would also need a retry counter to prevent endlessly retrying undownloadable media.

@tcely
Copy link
Contributor Author

tcely commented Jan 25, 2025

I was thinking about a refresh_formats task that is scheduled after we complain about the file not being where we expected.

We would have to not schedule a lot of those, but it should be fine if it happens to run after a successful download too.

@meeb
Copy link
Owner

meeb commented Jan 25, 2025

A reasonable idea, likely it might need both. That wouldn't catch, for example, private members videos which have no format matches but are then made public later as the download would never be attempted and not trigger a metadata refresh.

@tcely
Copy link
Contributor Author

tcely commented Jan 25, 2025

It seems like when can_download==False and there is metadata we should also schedule a refresh_formats task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants