Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request - Change "Sync Now" Icon to Button for Mobile Compatibility #641

Open
bawitdaba opened this issue Jan 23, 2025 · 2 comments

Comments

@bawitdaba
Copy link

in sync\templates\sync\sources.html (https://github.com/meeb/tubesync/blob/main/tubesync/sync/templates/sync/sources.html)

Change Line 27

From
<span class="collection-item flex-collection-container">

To
<span class="collection-item flex-collection-container" style="display: block !important; overflow-wrap: anywhere;">

Change Line 37

From
<a href="{% url 'sync:source-sync-now' pk=source.pk %}" class="collection-item"><i class="fas fa-arrow-rotate-right"></i></a>

To
<a href="{% url 'sync:source-sync-now' pk=source.pk %}" class="btn">Sync Now</a>

This results in the following change:

Before:
Image

After:
Image

Thanks

  • Bawitdaba
@tcely
Copy link
Contributor

tcely commented Jan 23, 2025

Thanks for the proposal!

Would you please make a pull request with the changes?

@meeb
Copy link
Owner

meeb commented Jan 23, 2025

Thanks! No objection to this change, but the bug is probably the button not appearing on mobile in the first place. CSS changes should be done in SASS as well. If you're not comfortable with that just submit the PR and I can tweak it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants