Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base orientation of frames in the rider #91

Open
tjstienstra opened this issue Aug 15, 2023 · 2 comments
Open

Change base orientation of frames in the rider #91

tjstienstra opened this issue Aug 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tjstienstra
Copy link
Collaborator

In a feedback session Jason Moore mentioned that there are standards with biomechanical modeling on how to orient reference frames w.r.t. the body and that it would be better to follow those within BRiM even though the current orientation, which follows the bicycle convention, has other practical advantages. Overall, I agree with him on this point. The fix should not be to difficult as it is just a rotation about the X-axis of 180 degrees. However, special attention is required to make sure no mistakes also in the automatic parameterization are made.

@tjstienstra tjstienstra added the enhancement New feature or request label Aug 15, 2023
@moorepants
Copy link
Collaborator

This is an example paper: https://doi.org/10.1016/S0021-9290(01)00222-6 with the coordinate systems. There is a part 2 also.

It may not be worth implementing, but should be considered (at a later date).

@moorepants
Copy link
Collaborator

There is this one too: https://doi.org/10.1016/j.jbiomech.2019.109533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants