-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Create with element instead of ID #59
Comments
Interesting, can you point me to some references on how libraries are used with shadowRoot? |
Hi @mebjas, |
I see, thanks for sharing this. I'll start working on this to see if I can add the support. But to be honest, the library internally uses element id in many places and this'd involve some rework. |
as there is some workaround .. we can use to "move" a root element into a CustomElement, the library is not unusable. So yes i suppose there's some rework :S, i'll hope i can help with this. |
+1 for this. First step would be to refactor code to only call getElementById once, and only work with elements directly after that point. For example this code:
Does not need to assign an ID. Instead the element could be held as a value and passed to the contexts that need to use this element. |
Hi,
we should have a way to create a reader with an HTMLElement instead of an ID. In case of using shadowRoot, application should not be able to find element with document.getElementById.
Cheers,
The text was updated successfully, but these errors were encountered: