Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html5QrcodeScanner needs css fix #53

Closed
mebjas opened this issue Jun 7, 2020 · 4 comments
Closed

Html5QrcodeScanner needs css fix #53

mebjas opened this issue Jun 7, 2020 · 4 comments

Comments

@mebjas
Copy link
Owner

mebjas commented Jun 7, 2020

The demo page running Html5QrcodeScanner has more modern UI because of existing dependencies in the webpage.

OTOH, without any existing css the UI is much primitive.

This gives an advantage that the UI of the scanner can implicitly match the theme of the website it's attached to.

Considering pros and cons - make minimal fixes to the style or alternatively make this configurable.

@Qiming-Liu
Copy link

Qiming-Liu commented May 29, 2021

Hi mebjas, I really love your html5-qrcode.
I just write a simple CSS theme for it.

Html5-QRCode-CSS

@mebjas
Copy link
Owner Author

mebjas commented May 30, 2021

Hi mebjas, I really love your html5-qrcode.
I just write a simple CSS theme for it.

@Qiming-Liu Thanks for sharing this.

Additionally,
We need more of a UI overhaul as described in #207 which changes some of the existing issues, redundancies, internationalization issues and probably even allow developers to customize the style without having to implement on top of Html5Qrcode directly.

Looking forward to hear more feedbacks on this soon for designers/UXRs

@mebjas
Copy link
Owner Author

mebjas commented May 30, 2021

Started a discussion for this - #213

@mebjas
Copy link
Owner Author

mebjas commented Oct 29, 2022

Marking this as a duplicate of #389

Let's have more discussion there.

@mebjas mebjas closed this as completed Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants