-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognized scan-region for small viewports #26
Comments
Maybe related to #21 ? |
In that case I'll fix #21 first and we can see if this is still an issue |
That would be great! Hope you'll find time as soon as possible. Just asking a bit obtrusive, cause the core of my project depends on your solution and I already checked out other libs. But either they are not really maintained and extremely buggy or to complex to integrate (e.g. they require server-side processing which is not an applicable use-case for me). Just FYI: I'm working on an open-source covid19-project :-) |
@OneDivZero I have fixed #21 with a recent push. I have also updated the demo code Can you validate if it fixes this issue for you? |
Yes that looks great ... It works on my iPhone as expected. I will acquire some friends for doing a test on different devices for further confirmation. Thank you! |
Thanks for confirmation! |
@OneDivZero Closing this issue, feel free to reopen if this is found in some other device/browser or create a new issue. |
kk ... will share my test-results in a new issue btw: I picked up the latest script (2 days ago) from github, but I don't see the nice green edges? |
@OneDivZero - Can you check for console logs, the white/green edges should be visible if there is enough region left in the viewfinder to render based on width and the qrbox size configured. Also, since looking for logs in mobile devices is harder, I was thinking if I should add a debug option which somehow makes more logs / error visible. What do you think? |
Bug
There seems to be a problem with the recognized scan-region for small viewports. I printed a qr-code in the size of a hand and I'm trying it to scan with an iPhone 7 using a qr-box with 350x350px (and boxsize in code is not set, thus it should use full dimension).
You have to hold your phone about 0,5m far away only for having a chance to get a match. And then it only succeeds in round about one out of ten trials. It works great with macbook-cam, when using a qr-box with more than 600+ px. But reducing step by step the size also works bad on desktop browser.
Describe the browser:
Screenshots
Fails on desktop too:
Additional context
Box: 350x350
BoxSize in JS: null
I can provide a playground if required.
The text was updated successfully, but these errors were encountered: