Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility - [Android 11] [Chrome 88.0 ] - [Call stopScan will cause crash] #159

Closed
bastienWang opened this issue Feb 1, 2021 · 5 comments

Comments

@bastienWang
Copy link

Describe the bug
I use my phone link to Demo site, I repeated the start scanning and stop scanning, browser will cause crash.

Describe the browser:

  • OS: [Android 11]
  • Browser [Chrome]
  • Version [88.0]

Additional context
If use Chrome 83.0 is OK.

@MrGussio
Copy link
Contributor

@bastienWang As you might see in the activity feed of this issue, I have found a solution to this issue. If you just use the compiled JS files, they can be found already in the pull request contents.

@jdtimmerman
Copy link
Contributor

This issue is still present and I can confirm that @MrGussio´s change (which i rebased onto the current master) solves this issue for me (on Chrome 89). @mebjas could you please triage this? I´d say it´s an high-prio issue.

I did notice one of the tests are failing, but I also had some issues with the transpiling so this could just be an issue on my environment.

@MrGussio
Copy link
Contributor

@jdtimmerman I had some transpiling issues too - IIRC I eventually managed to do it by hand using Babel. Good to know that the fix also works for the most recent master version.

@mebjas
Copy link
Owner

mebjas commented Apr 17, 2021

Thanks for reporting the issue and thanks @MrGussio for the fix & @jdtimmerman for the verification.

Added a comment to the PR, happy to merge asap. (Sorry have been a busy lately).

@mebjas
Copy link
Owner

mebjas commented Apr 26, 2021

Thanks for the fix @MrGussio - it has been merged and published.

Closing this issue now.

@mebjas mebjas closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants