Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore elimination of edit wrappers #455

Closed
chrisvxd opened this issue Apr 19, 2024 · 2 comments · Fixed by #598
Closed

Explore elimination of edit wrappers #455

chrisvxd opened this issue Apr 19, 2024 · 2 comments · Fixed by #598

Comments

@chrisvxd
Copy link
Member

Puck introduces various wrappers during edit mode to provide drag-and-drop and edit functionality. This can result in different interface between edit and render modes, such as:

  • children containing different nodes
  • CSS Grid styles across DropZones not being possible in edit mode, even if it works in render mode
  • Inline elements do not render correctly in edit mode (Inline CSS #4)

We should explore ways to eliminate these styles without compromising the Puck interface. A solution may or may not involve breaking changes.

@sagarchoudhary96
Copy link
Contributor

@chrisvxd any updates on this one ?

@chrisvxd
Copy link
Member Author

Yes - it's currently in progress as part of efforts to support #123, which is requiring a drag-and-drop engine rebuild. Will update the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants