Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Recipe comments display a username/id rather than the "name" of the user #4187

Open
6 tasks done
boc-the-git opened this issue Sep 10, 2024 · 2 comments
Open
6 tasks done
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers

Comments

@boc-the-git
Copy link
Collaborator

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When you add a comment to a recipe, it displays the username/id, rather than the "name" of the user.

Specifically it comes from here:

<p class="">{{ comment.user.username }} • {{ $d(Date.parse(comment.createdAt), "medium") }}</p>

Steps to Reproduce

  1. Add a comment to a recipe

Please provide relevant logs

N/A

Mealie Version

Version
v1.12.0
Build
0d06494

Deployment

Docker (Linux)

Additional Deployment Details

No response

@boc-the-git boc-the-git added bug Something isn't working good first issue Good for newcomers triage labels Sep 10, 2024
@boc-the-git
Copy link
Collaborator Author

I raised this as an issue to give anyone a chance to object to this being changed. It straddles bug and feature request IMO.

@michael-genson
Copy link
Collaborator

Oh yeah that should definitely be name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants