fix(baseline): hide banner on subgrid #9979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subgrid should be baseline "green" by the old design and definition, but we are hopefully close to announcing a new definition and designs - it would be odd to change the banner on subgrid once, only to immediately change it again - so hiding it for now
caugner
approved these changes
Nov 8, 2023
gurezo
pushed a commit
to gurezo/yari
that referenced
this pull request
Nov 11, 2023
subgrid should be baseline "green" by the old design and definition, but we are hopefully close to announcing a new definition and designs - it would be odd to change the banner on subgrid once, only to immediately change it again - so hiding it for now
gurezo
pushed a commit
to gurezo/yari
that referenced
this pull request
Nov 11, 2023
subgrid should be baseline "green" by the old design and definition, but we are hopefully close to announcing a new definition and designs - it would be odd to change the banner on subgrid once, only to immediately change it again - so hiding it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
subgrid should be baseline "green" by the old design and definition
Solution
we are hopefully close to announcing a new definition and designs - it would be odd to change the banner on subgrid once, only to immediately change it again - so hiding it for now
How did you test this change?
yarn dev& visited: