Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pong): update mapping #9884

Merged
merged 4 commits into from
Nov 6, 2023
Merged

chore(pong): update mapping #9884

merged 4 commits into from
Nov 6, 2023

Conversation

fiji-flo
Copy link
Contributor

Summary

Just adjusting API changes.
Incorporating alt in a follow up.

@fiji-flo fiji-flo requested a review from caugner October 26, 2023 10:48
caugner
caugner reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test this?

@fiji-flo
Copy link
Contributor Author

It's on stage.

caugner
caugner approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ads look good on stage, so LGTM.

PS: I didn't see alt texts though, but I assume they're not configured for the ads I saw.

@fiji-flo fiji-flo requested a review from a team as a code owner October 31, 2023 09:52
caugner

This comment was marked as duplicate.

Sign in to view

caugner
caugner approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can see ads with alt texts on stage.

Note: I didn't see any top banner, so I wasn't able to verify that the CTA text shows up.

@fiji-flo fiji-flo merged commit 6c044cc into main Nov 6, 2023
@fiji-flo fiji-flo deleted the pong-rename-bsa branch November 6, 2023 09:12
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
placement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiji-flo @caugner