Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): support v20 + suppress experimental warnings #9517

Merged
merged 4 commits into from
Nov 7, 2023
Merged

fix(node): support v20 + suppress experimental warnings #9517

merged 4 commits into from
Nov 7, 2023

Conversation

sideshowbarker
Copy link
Member

Relates to mdn/content#28655

@sideshowbarker sideshowbarker mentioned this pull request Aug 20, 2023
Merged
@OnkarRuikar
Copy link
Contributor

Do we need to update "node": ">=18.16.0" as well?

stop using nvm

What is an alternative to switching to different version of node while working on other open source projects?

bsmth
bsmth requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions, although I'd leave a -1 on removing the .nvmrc, this is useful for local development and for CI

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Aug 22, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner caugner requested a review from mdn-bot as a code owner November 7, 2023 19:36
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Nov 7, 2023
@caugner caugner requested a review from a team as a code owner November 7, 2023 19:46
@caugner caugner changed the title Enable building with Node v20; stop using nvm; suppress spurious warnings fix(node): support v20 + disable experimental warnings Nov 7, 2023
@caugner caugner changed the title fix(node): support v20 + disable experimental warnings fix(node): support v20 + suppress experimental warnings Nov 7, 2023
@caugner caugner enabled auto-merge (squash) November 7, 2023 19:57
caugner
caugner approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reverted the .nvmrc deletion as part of the merge.

@caugner caugner requested a review from bsmth November 7, 2023 20:02
@caugner caugner disabled auto-merge November 7, 2023 20:03
@caugner caugner merged commit 4401c3e into main Nov 7, 2023
@caugner caugner deleted the sideshowbarker/enable-node-v20 branch November 7, 2023 20:03
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
@sideshowbarker @gurezo
fix(node): support v20 + suppress experimental warnings (mdn#9517)
00f6ae9
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
@sideshowbarker @gurezo
fix(node): support v20 + suppress experimental warnings (mdn#9517)
5763e2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

@bsmth bsmth Awaiting requested review from bsmth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sideshowbarker @OnkarRuikar @caugner @bsmth