Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-translated-content tool won't sync the case change of slug #7778

Closed
3 tasks done
yin1999 opened this issue Dec 9, 2022 · 0 comments · Fixed by #7886
Closed
3 tasks done

sync-translated-content tool won't sync the case change of slug #7778

yin1999 opened this issue Dec 9, 2022 · 0 comments · Fixed by #7886
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected localization i18n & l10n p2 We want to address this but may have other higher priority items. tool:sync-translated-content wx writer experience

Comments

@yin1999
Copy link
Member

yin1999 commented Dec 9, 2022

Summary

sync-translated-content tool is not work under slug case sensitive mode, so the slug in translated content may not equal with the one in content.

See

https://github.com/mdn/translated-content/blob/b2cc024aa2e9d361d1f820d435747704ff3999de/files/zh-cn/web/html/element/input/index.md?plain=1#L3

https://github.com/mdn/content/blob/d70965a517f1b66e1b1722430db35b2097b71e3b/files/en-us/web/html/element/input/index.md?plain=1#L3

URL

N/A

Reproduction steps

N/A

Expected behavior

This tool could also sync the case changes of slug.

Actual behavior

N/A

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Windows

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 9, 2022
@yin1999 yin1999 changed the title sync-translated-content tool won't sync the **case change** of slug sync-translated-content tool won't sync the case change of slug Dec 9, 2022
@caugner caugner added 🐛 bug Something isn't working, or isn't working as expected localization i18n & l10n p2 We want to address this but may have other higher priority items. wx writer experience tool:sync-translated-content accepting PR We invite you to open a PR to resolve this issue. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected localization i18n & l10n p2 We want to address this but may have other higher priority items. tool:sync-translated-content wx writer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants