Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Persist language selection #5498

Closed
mt-webdev opened this issue Mar 7, 2022 · 11 comments
Closed

Suggestion: Persist language selection #5498

mt-webdev opened this issue Mar 7, 2022 · 11 comments
Labels
🌱 feature-request new feature request or enhancements to existing features localization i18n & l10n need more info Further information is requested

Comments

@mt-webdev
Copy link

mt-webdev commented Mar 7, 2022

Summary

Unfortunately, the language selection is not being persisted, which means on every visit I have to reselect my wanted language (which is English)

Where did you spot the bug?

Literally any site:
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector

What is the problem?

The site is currently not able to persist in the user/session settings.

What did you expect to happen?

Once I revisit the site I would like to memorize my language selection ( & theme as well, but less of a bummer)

Steps to reproduce the issue

  1. Open https://developer.mozilla.org/... in Chrome
  2. use the language selector on the top right opposite of the breadcrumbs.
  3. close the site
  4. a couple of hours/days later re-visit

Environment

Device

  • [x ] Desktop

Browser

  • [ x] Chrome: 98.0.4758.109

Operating system

  • [ x] Mac OS: 12.2.1
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 7, 2022
@schalkneethling schalkneethling added the redesign issues related to the new design label Mar 7, 2022
@schalkneethling
Copy link
Contributor

Unfortunately, the language selection is not being persisted, which means on every visit I have to reselect my wanted language (which is English)

I am guessing you mean when leaving MDN and later returning via a search result? It seems to work fine if you change the language and navigate around MDN. Thank you for reporting @mt-webdev

@schalkneethling schalkneethling changed the title Bug: <TITLE OF PROBLEM> Bug: language selection is not being persisted Mar 7, 2022
@schalkneethling schalkneethling removed the redesign issues related to the new design label Mar 8, 2022
@caugner
Copy link
Contributor

caugner commented Mar 9, 2022

@mt-webdev Would it be a solution for you to make English the preferred language in your Chrome settings?

And if not, why not?

image

@caugner caugner added localization i18n & l10n need more info Further information is requested labels Mar 9, 2022
@caugner caugner changed the title Bug: language selection is not being persisted Suggestion: Persist language selection Mar 9, 2022
@caugner caugner added the 🌱 feature-request new feature request or enhancements to existing features label Mar 9, 2022
@mt-webdev
Copy link
Author

mt-webdev commented Mar 9, 2022

@schalkneethling yes, that's also a scenario where it's changing my preferences. (visit via Search-Engines)
@caugner I would like to keep my browser settings as-is.

@caugner
Copy link
Contributor

caugner commented Mar 9, 2022

@mt-webdev Just to understand: Can you elaborate on why you like to keep your browser preferring a different language than you actually prefer? Are there other sites that would then appear in English, although you prefer them in the language currently preferred by your browser?

(Note that, at least in Firefox, you can have the browser UI in one language and still prefer a different language.)

@schalkneethling
Copy link
Contributor

@mt-webdev Would it be a solution for you to make English the preferred language in your Chrome settings?

And if not, why not?

I believe the problem is that the reader wants to have MDN Web Docs always in English. If they change the setting in Chrome, then I believe all(or most) websites they visit will honour the selection and always show English content.

@schalkneethling
Copy link
Contributor

@schalkneethling yes, that's also a scenario where it's changing my preferences. (visit via Search-Engines)

Yes, that is a problem we have not solved for. With that said, there is a rather old pull request that does address this:
#3968

We would need to pick this up again and get it merged but, we will have to speak with the product owner to set priority for when we do this work.

@apapsch
Copy link

apapsch commented Mar 14, 2022

English content is usually more up-to-date, hence the preference of English on MDN, whereas the browser is set to prefer another language. In the old MDN, the problem was solved eventually by making it easy to access the English page (a link in the top right corner, "Go to English page") and IIRC the choice was saved.

@schalkneethling
Copy link
Contributor

English content is usually more up-to-date, hence the preference of English on MDN, whereas the browser is set to prefer another language. In the old MDN, the problem was solved eventually by making it easy to access the English page (a link in the top right corner, "Go to English page") and IIRC the choice was saved.

I do not believe the choice was saved but yes, the quick link to English was useful to some folks. We can solve this problem by taking the following pull request across the finish line, so to speak. #3968

We will need to prioritise the work though. @HerminaC and @fiji-flo Thoughts?

@mt-webdev
Copy link
Author

I never noticed this "issue" while using the previous MDN version. I am not sure why I end up on (in my case) german MDN sometimes... :-/

@NHerw
Copy link

NHerw commented May 2, 2022

Now that we also have MDN Plus in german speaking countries, can we save our preferred language in our mozilla account?

@schalkneethling
Copy link
Contributor

@mt-webdev Thank you for starting this conversation. I have moved this to a discussion here: https://github.com/orgs/mdn/discussions/97

@schalkneethling schalkneethling removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 feature-request new feature request or enhancements to existing features localization i18n & l10n need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants