feat: add <interactive-example> custom element #12413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was ready this was noticeable every so often when opening a live sample in the playground
github-actions
bot
added
dependencies
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
allow clear/formatting immediately when opening example only enable share if there's non-whitespace update button state after formatting code
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
…gating back to docs page
fiji-flo
approved these changes
Jan 22, 2025
| height: 513px; | ||
| margin: 1rem 0; | ||
|
|
||
| &[height="shorter"] { |
There was a problem hiding this comment.
I guess we want to change this to reflect the current ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mozilla-hub.atlassian.net/browse/MP-1804
Replaces #12283 and #12252
Adds these custom elements:
<interactive-example>: not used anywhere yet, needs me to open a corresponding PR in rari<play-controller>: used for common logic between the playground and interactive examples<play-editor><play-runner>Also implements a
glean-clickevent to allow callinggleanClickfrom lit-land, in order to partially re-implement the interactive example pings we send (sans event count).Some outstanding issues we might need to discuss before merging:No use of code fence special classes, currently: these wouldn't help hiding them from css as the class is applied to the<pre>within the.code-example<div>which needs to be hidden, so a pure css approach would require using a selector like.code-example:has(pre.interactive-example)Code text gets bigger on mobile, and is smaller than the existing interactive examples size on desktop: being the same as the current sizes in the playgroundHow did you test this change?
So far, locally on localhost:3000
on https://developer.allizom.org/en-US/play for playground changes
on https://test.developer.allizom.org/en-US/docs/Web/JavaScript for testing migrated examples - though I suggest we don't let that block merging this, as they won't appear anywhere until the corresponding rari PR is merged (and we actually start migrating examples)