-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rari): propagate rari exit code #12397
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Co-authored-by: Florian Dieminger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Summary
Problem
#12351 showed that
yarn tool whatsdeployed
is not working but doesn't break CI, because runningyarn tool
always finishes with exit code 0, even if the underlying rari call fails.Solution
Propagate the exit code from the rari call.
Screenshots
Before
After
How did you test this change?
Ran
yarn tool whatsdeployed
onmain
and this branch, see above.