Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images do not fall back to en-US #12334

Closed
3 tasks done
nyan-dot opened this issue Dec 18, 2024 · 3 comments
Closed
3 tasks done

Images do not fall back to en-US #12334

nyan-dot opened this issue Dec 18, 2024 · 3 comments
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@nyan-dot
Copy link

nyan-dot commented Dec 18, 2024

Summary

It seems that image files do not fall back to en-US across all locales and pages.

URL

https://developer.mozilla.org/ja/docs/Learn/Getting_started_with_the_web/CSS_basics

Reproduction steps

  1. Navigate to a page in a locale where images are expected to be present.

Expected behavior

The images from en-US should be displayed.

Actual behavior

A broken image icon is displayed as if the images do not exist.

Device

Smartphone

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

Screenshot_20241219-054014

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 18, 2024
@yin1999
Copy link
Member

yin1999 commented Dec 19, 2024

We used to copy the images from en-US to l10n folders (#7917, which can prevent the broken images in documents as well as in livesamples)

We may implement the function in rari as well.

@nyan-dot
Copy link
Author

Understood. I look forward to seeing the images restored!

@fiji-flo
Copy link
Contributor

resolved via #12335

We now do this in the cloud function and I missed the casing in there 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

3 participants