feat(playground): support state param in playground #12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
LeoMcA
reviewed
Nov 22, 2024
client/src/playground/index.tsx
Outdated
| } else if (stateParam) { | ||
| try { | ||
| let { state } = await decompressFromBase64(stateParam); | ||
| console.log(state); |
There was a problem hiding this comment.
Suggested change
| console.log(state); |
client/src/playground/index.tsx
Outdated
| let { state } = await decompressFromBase64(stateParam); | ||
| console.log(state); | ||
| let code = JSON.parse(state || "{}") as EditorContent; | ||
| console.log(code); |
There was a problem hiding this comment.
Suggested change
| console.log(code); |
| return bytes.buffer; | ||
| } | ||
|
|
||
| export async function decompressFromBase64(base64String: string) { |
There was a problem hiding this comment.
Looks like the only difference between this and the function in libs/play/index.js is the use of the above base64ToBytes instead of Buffer.from - which I presume is a node built in. But could we move the above function into libs/play/index.js as well and use this code in node as well? It would be nice to use the same code in both places.
There was a problem hiding this comment.
Ah, it's a bit of a pain isn't it - would need to extract the node specific bits into another file in the lib - the current form is ok
There was a problem hiding this comment.
I agree in principal. But I'd want to look at this a bit deeper. The base64ToBytes is rather inefficient, and that's probably one the expensive paths in the cloud function. I'll add a task to investigate but wouldn't block on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not actively used except for the open in playground button on full screen live samples
Problem
open in playground button brings the user to an empty playground.
Solution
Load the content into the playground.
How did you test this change?
locally