-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(baseline): support ranged dates, use upstream types #11536
Conversation
Bumps [web-features](https://github.com/web-platform-dx/web-features) from 0.9.0 to 1.0.0. - [Release notes](https://github.com/web-platform-dx/web-features/releases) - [Commits](web-platform-dx/web-features@v0.9.0...v1.0.0) --- updated-dependencies: - dependency-name: web-features dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait until the following aspect of this comment is discussed:
One last thing: strictly speaking, "since before" in the Baseline banner may not be correct. The meaning of a ≤ date is closer to "no later than" or "at worst."
(I had a similar weird feeling about "Since before", but didn't question it, because it was explicitly mentioned in the Jira ticket, suggesting to me that this wording had been decided together with stakeholders.)
Summary
https://mozilla-hub.atlassian.net/browse/MP-1393
Problem
Solution
How did you test this change?
yarn
yari/node_modules/web-features/data.json
to add some<
,>
,≤
and≥
characters before variousbaseline_low_date
syarn dev