fix(baseline): support ranged dates, use upstream types #11536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [web-features](https://github.com/web-platform-dx/web-features) from 0.9.0 to 1.0.0. - [Release notes](https://github.com/web-platform-dx/web-features/releases) - [Commits](web-platform-dx/web-features@v0.9.0...v1.0.0) --- updated-dependencies: - dependency-name: web-features dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
github-actions
bot
added
the
dependencies
caugner
requested changes
Jul 25, 2024
caugner
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
LGTM, but let's wait until the following aspect of this comment is discussed:
One last thing: strictly speaking, "since before" in the Baseline banner may not be correct. The meaning of a ≤ date is closer to "no later than" or "at worst."
(I had a similar weird feeling about "Since before", but didn't question it, because it was explicitly mentioned in the Jira ticket, suggesting to me that this wording had been decided together with stakeholders.)
LeoMcA
changed the title
LeoMcA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mozilla-hub.atlassian.net/browse/MP-1393
Problem
Solution
How did you test this change?
yarnyari/node_modules/web-features/data.jsonto add some<,>,≤and≥characters before variousbaseline_low_datesyarn dev