Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(baseline): support ranged dates, use upstream types #11536

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 24, 2024

  • chore(deps): bump web-features from 0.9.0 to 1.0.0
  • fix(web-features): use upstream types
  • feat(baseline): support ranged dates

Summary

https://mozilla-hub.atlassian.net/browse/MP-1393

Problem

Solution

  • use types from upstream
  • support ranged dates (we don't use version numbers anywhere)

How did you test this change?

  • yarn
  • edited yari/node_modules/web-features/data.json to add some <, >, and characters before various baseline_low_dates
  • yarn dev
  • visited the relevant pages given the features I'd modified, and some unmodified pages, took screenshots

dependabot bot and others added 3 commits July 22, 2024 11:24
Bumps [web-features](https://github.com/web-platform-dx/web-features) from 0.9.0 to 1.0.0.
- [Release notes](https://github.com/web-platform-dx/web-features/releases)
- [Commits](web-platform-dx/web-features@v0.9.0...v1.0.0)

---
updated-dependencies:
- dependency-name: web-features
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@LeoMcA LeoMcA requested review from mdn-bot and a team as code owners July 24, 2024 16:22
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 24, 2024
@LeoMcA LeoMcA requested a review from caugner July 25, 2024 09:17
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until the following aspect of this comment is discussed:

One last thing: strictly speaking, "since before" in the Baseline banner may not be correct. The meaning of a ≤ date is closer to "no later than" or "at worst."

(I had a similar weird feeling about "Since before", but didn't question it, because it was explicitly mentioned in the Jira ticket, suggesting to me that this wording had been decided together with stakeholders.)

@LeoMcA LeoMcA changed the title feat(baseline): support ranged dates fix(baseline): update web-features to 1.0.0 Jul 25, 2024
@LeoMcA LeoMcA changed the title fix(baseline): update web-features to 1.0.0 fix(baseline): support ranged dates, use upstream types Jul 25, 2024
@LeoMcA LeoMcA merged commit 2782f97 into main Jul 25, 2024
16 checks passed
@LeoMcA LeoMcA deleted the web-features-ranged branch July 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants