Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/AddonSidebar*): update zh-CN translation #11231

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jun 1, 2024

Summary

update the translation of zh-cn for {{AddonSidebar}} and {{AddonSidebarMain}}

Problem

Solution


Screenshots

Before

image

image

After

image

image


How did you test this change?

watch the develop result


/cc @yin1999 @JasonLamv-t @jasonren0403

part of the mdn/translated-content#13881

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jun 1, 2024
@skyclouds2001 skyclouds2001 changed the title [zh-cn]: add & sync translation for AddonSidebar and AddonSidebarMain [zh-cn]: add & sync translation for AddonSidebar and AddonSidebarMain macros Jun 1, 2024
@caugner
Copy link
Contributor

caugner commented Jun 6, 2024

@skyclouds2001 Thank you for your PR. Please make sure to fill out the PR description, including screenshots, to make it easier for reviewers. 🙏

@caugner caugner requested a review from yin1999 June 6, 2024 20:13
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit. Otherwise LGTM. Thank you @skyclouds2001

kumascript/macros/AddonSidebar.ejs Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 requested a review from yin1999 June 12, 2024 11:36
@skyclouds2001 skyclouds2001 marked this pull request as ready for review June 12, 2024 11:39
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner June 12, 2024 11:39
@caugner caugner changed the title [zh-cn]: add & sync translation for AddonSidebar and AddonSidebarMain macros chore(macros/AddonSidebar*): update zh-CN translation Jun 14, 2024
@caugner caugner merged commit 1609a74 into mdn:main Jun 14, 2024
10 checks passed
@skyclouds2001 skyclouds2001 deleted the addon branch June 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants