Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add popularities to "yarn start" script #10718

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 18, 2024

Summary

Related to: #10653 (comment)

Problem

yarn start fails on a fresh checkout, with the following error:

error: ENOENT: no such file or directory, open '/path/to/yari/popularities.json'

Solution

Run yarn tool popularities as part of yarn start, if the popularities.json doesn't exist.


How did you test this change?

Ran yarn start on a fresh checkout, and I was able open http://localhost:3000/ afterwards.

package.json Outdated Show resolved Hide resolved
@caugner caugner added the dx developer experience label Mar 18, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as the fix is trivial.

@caugner caugner merged commit f07a42a into main Mar 18, 2024
16 checks passed
@caugner caugner deleted the fix-yarn-start-add-popularities branch March 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant